* [patch 2/2] jffs2: use cond_resched() instead of yield()
@ 2010-10-01 21:16 akpm
2010-10-02 14:07 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: akpm @ 2010-10-01 21:16 UTC (permalink / raw)
To: dwmw2; +Cc: Artem.Bityutskiy, dedekind, w.sang, linux-mtd, akpm, mingo
From: Wolfram Sang <w.sang@pengutronix.de>
yield() has different semantics meanwhile and even causes RT-kernels to
BUG. Replace the only appearance left in jffs2.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Artem Bityutskiy <dedekind@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/jffs2/erase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/jffs2/erase.c~jffs2-use-cond_resched-instead-of-yield fs/jffs2/erase.c
--- a/fs/jffs2/erase.c~jffs2-use-cond_resched-instead-of-yield
+++ a/fs/jffs2/erase.c
@@ -151,7 +151,7 @@ int jffs2_erase_pending_blocks(struct jf
}
/* Be nice */
- yield();
+ cond_resched();
mutex_lock(&c->erase_free_sem);
spin_lock(&c->erase_completion_lock);
}
_
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 2/2] jffs2: use cond_resched() instead of yield()
2010-10-01 21:16 [patch 2/2] jffs2: use cond_resched() instead of yield() akpm
@ 2010-10-02 14:07 ` Artem Bityutskiy
2010-10-02 19:10 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Artem Bityutskiy @ 2010-10-02 14:07 UTC (permalink / raw)
To: akpm; +Cc: Artem.Bityutskiy, dedekind, w.sang, linux-mtd, mingo, dwmw2
On Fri, 2010-10-01 at 14:16 -0700, akpm@linux-foundation.org wrote:
> From: Wolfram Sang <w.sang@pengutronix.de>
>
> yield() has different semantics meanwhile and even causes RT-kernels to
> BUG. Replace the only appearance left in jffs2.
>
This patch is also in my l2-mtd-2.6.git tree.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 2/2] jffs2: use cond_resched() instead of yield()
2010-10-02 14:07 ` Artem Bityutskiy
@ 2010-10-02 19:10 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2010-10-02 19:10 UTC (permalink / raw)
To: dedekind1; +Cc: Artem.Bityutskiy, dedekind, w.sang, linux-mtd, mingo, dwmw2
On Sat, 02 Oct 2010 17:07:55 +0300 Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Fri, 2010-10-01 at 14:16 -0700, akpm@linux-foundation.org wrote:
> > From: Wolfram Sang <w.sang@pengutronix.de>
> >
> > yield() has different semantics meanwhile and even causes RT-kernels to
> > BUG. Replace the only appearance left in jffs2.
> >
>
> This patch is also in my l2-mtd-2.6.git tree.
And I'll keep sending it and you'll keep telling me it's in your tree
until this situation gets fixed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [patch 2/2] jffs2: use cond_resched() instead of yield()
@ 2010-10-20 22:59 akpm
0 siblings, 0 replies; 4+ messages in thread
From: akpm @ 2010-10-20 22:59 UTC (permalink / raw)
To: dwmw2; +Cc: Artem.Bityutskiy, dedekind, w.sang, linux-mtd, akpm, mingo
From: Wolfram Sang <w.sang@pengutronix.de>
yield() has different semantics meanwhile and even causes RT-kernels to
BUG. Replace the only appearance left in jffs2.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Artem Bityutskiy <dedekind@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/jffs2/erase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/jffs2/erase.c~jffs2-use-cond_resched-instead-of-yield fs/jffs2/erase.c
--- a/fs/jffs2/erase.c~jffs2-use-cond_resched-instead-of-yield
+++ a/fs/jffs2/erase.c
@@ -151,7 +151,7 @@ int jffs2_erase_pending_blocks(struct jf
}
/* Be nice */
- yield();
+ cond_resched();
mutex_lock(&c->erase_free_sem);
spin_lock(&c->erase_completion_lock);
}
_
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-20 22:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-01 21:16 [patch 2/2] jffs2: use cond_resched() instead of yield() akpm
2010-10-02 14:07 ` Artem Bityutskiy
2010-10-02 19:10 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2010-10-20 22:59 akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).