From: Artem Bityutskiy <dedekind1@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] sumtool/libfec: convert "()" to "(void)" in func defs
Date: Sat, 02 Oct 2010 17:17:02 +0300 [thread overview]
Message-ID: <1286029022.32172.21.camel@brekeke> (raw)
In-Reply-To: <1285953088-19593-2-git-send-email-vapier@gentoo.org>
On Fri, 2010-10-01 at 13:11 -0400, Mike Frysinger wrote:
> Since these functions take no parameters, declare them as such. The
> subtle difference here is that gcc allows (without warning) people to
> accidentally call funcs declared with "()" with arguments. Using void
> makes sure that gcc will reject such typos at compile time.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Pushed, thanks!
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
next prev parent reply other threads:[~2010-10-02 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 17:11 [PATCH 1/2] sumtool: convert to common.h helpers Mike Frysinger
2010-10-01 17:11 ` [PATCH 2/2] sumtool/libfec: convert "()" to "(void)" in func defs Mike Frysinger
2010-10-02 14:17 ` Artem Bityutskiy [this message]
2010-10-02 14:16 ` [PATCH 1/2] sumtool: convert to common.h helpers Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286029022.32172.21.camel@brekeke \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox