Re: [PATCH v3] OMAP: NAND: Fix static declaration warning

Re: [PATCH v3] OMAP: NAND: Fix static declaration warning

[Vimal Singh]

On Wed, Oct 6, 2010 at 3:26 AM, G, Manjunath Kondaiah <manjugk@ti.com> wrote:
> This patch fixes sparse warning for static declaration of variable "use_dma"
>
> drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. Should it be static?
>
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mtd@lists.infradead.org
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
> Changes since v1:
>  - no logical changes, patch seperated from series based Tony's suggestion.
>
>  drivers/mtd/nand/omap2.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 133d515..439e80d 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -111,11 +111,11 @@ static int use_dma = 1;
>  module_param(use_dma, bool, 0);
>  MODULE_PARM_DESC(use_dma, "enable/disable use of DMA");
>  #else
> -const int use_dma;
> +static const int use_dma;
>  #endif
>  #else
>  const int use_prefetch;
> -const int use_dma;
> +static const int use_dma;

I did not understand, why did it not pointed same error for 'const int
use_prefetch'?

-- 
Regards,
Vimal Singh

Re: [PATCH v3] OMAP: NAND: Fix static declaration warning

[Artem Bityutskiy]

On Wed, 2010-10-06 at 03:26 +0530, G, Manjunath Kondaiah wrote:
> This patch fixes sparse warning for static declaration of variable "use_dma"
> 
> drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. Should it be static?
> 
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mtd@lists.infradead.org
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>

I've pushed this patch to my l2-mtd-2.6.git.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

Re: [PATCH v3] OMAP2/3: NAND: Convert write/read functions to raw read/write

[Artem Bityutskiy]

On Wed, 2010-10-06 at 03:26 +0530, G, Manjunath Kondaiah wrote:
> Following sparse warnings exists due to use of writel/w and readl/w functions.
> 
> This patch fixes the sparse warnings by converting readl/w functions usage into
> __raw_readl/__raw_readw functions.
> 
> drivers/mtd/nand/omap2.c:484:15: warning: symbol '__v' shadows an earlier one
> drivers/mtd/nand/omap2.c:484:15: originally declared here
> 
> drivers/mtd/onenand/omap2.c:86:9: warning: symbol '__v' shadows an earlier one
> drivers/mtd/onenand/omap2.c:86:9: originally declared here
> 
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-mtd@lists.infradead.org

I've pushed this patch to my l2-mtd-2.6.git.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)