* [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled
@ 2011-08-11 10:29 Michal Marek
2011-08-19 15:55 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Michal Marek @ 2011-08-11 10:29 UTC (permalink / raw)
To: dedekind1, adrian.hunter; +Cc: linux-mtd, linux-kernel
With
$ grep -e UBIFS_FS_DEBUG -e DYNAMIC_DEBUG .config
# CONFIG_UBIFS_FS_DEBUG is not set
CONFIG_DYNAMIC_DEBUG=y
Debug messages are kept in the object files due to the
dynamic_pr_debug() macro, even if they are never going to be printed:
$ make fs/ubifs/super.o
$ strings fs/ubifs/super.o | grep 'compiled on'
compiled on: Aug 11 2011 at 12:21:38
Use plain printk to fix this.
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
fs/ubifs/debug.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ubifs/debug.h b/fs/ubifs/debug.h
index 45174b5..5163a01 100644
--- a/fs/ubifs/debug.h
+++ b/fs/ubifs/debug.h
@@ -337,7 +337,7 @@ void dbg_debugfs_exit_fs(struct ubifs_info *c);
#define ubifs_dbg_msg(fmt, ...) do { \
if (0) \
- pr_debug(fmt "\n", ##__VA_ARGS__); \
+ printk(KERN_DEBUG fmt "\n", ##__VA_ARGS__); \
} while (0)
#define dbg_dump_stack()
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled
2011-08-11 10:29 [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled Michal Marek
@ 2011-08-19 15:55 ` Artem Bityutskiy
2011-08-19 16:08 ` Artem Bityutskiy
0 siblings, 1 reply; 3+ messages in thread
From: Artem Bityutskiy @ 2011-08-19 15:55 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-mtd, adrian.hunter, linux-kernel
On Thu, 2011-08-11 at 12:29 +0200, Michal Marek wrote:
> With
> $ grep -e UBIFS_FS_DEBUG -e DYNAMIC_DEBUG .config
> # CONFIG_UBIFS_FS_DEBUG is not set
> CONFIG_DYNAMIC_DEBUG=y
>
> Debug messages are kept in the object files due to the
> dynamic_pr_debug() macro, even if they are never going to be printed:
> $ make fs/ubifs/super.o
> $ strings fs/ubifs/super.o | grep 'compiled on'
> compiled on: Aug 11 2011 at 12:21:38
>
> Use plain printk to fix this.
>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
Good catch, thanks! Pushed to ubifs-2.6.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled
2011-08-19 15:55 ` Artem Bityutskiy
@ 2011-08-19 16:08 ` Artem Bityutskiy
0 siblings, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2011-08-19 16:08 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-mtd, adrian.hunter, linux-kernel
On Fri, 2011-08-19 at 18:55 +0300, Artem Bityutskiy wrote:
> On Thu, 2011-08-11 at 12:29 +0200, Michal Marek wrote:
> > With
> > $ grep -e UBIFS_FS_DEBUG -e DYNAMIC_DEBUG .config
> > # CONFIG_UBIFS_FS_DEBUG is not set
> > CONFIG_DYNAMIC_DEBUG=y
> >
> > Debug messages are kept in the object files due to the
> > dynamic_pr_debug() macro, even if they are never going to be printed:
> > $ make fs/ubifs/super.o
> > $ strings fs/ubifs/super.o | grep 'compiled on'
> > compiled on: Aug 11 2011 at 12:21:38
> >
> > Use plain printk to fix this.
> >
> > Signed-off-by: Michal Marek <mmarek@suse.cz>
>
> Good catch, thanks! Pushed to ubifs-2.6.git, thanks!
There is a similar issue in UBI - just fixed it. I'll send this to Linus
soon, as this is a regression (blown-up binaries even though debugging
is disabled).
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-19 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-11 10:29 [PATCH] ubifs: Do not build debug messages with CONFIG_UBIFS_FS_DEBUG disabled Michal Marek
2011-08-19 15:55 ` Artem Bityutskiy
2011-08-19 16:08 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox