Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH (mtd-utils)] Makefile: fixup previous 'make clean' fix
@ 2012-03-28 23:59 Brian Norris
  2012-03-29  3:30 ` Mike Frysinger
  2012-04-02  8:10 ` Artem Bityutskiy
  0 siblings, 2 replies; 3+ messages in thread
From: Brian Norris @ 2012-03-28 23:59 UTC (permalink / raw)
  To: Artem Bityutskiy; +Cc: Brian Norris, linux-mtd, Mike Frysinger

Apparently, Makefile comments need to be made without indentation. Otherwise,
they are printed out as shell commands. This fix prevents seeing this in your
shell during 'make clean':

  $ make clean
  ...
  # findutils v4.1.x (RHEL 4) do not have '+' syntax
  ...

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---

Artem, can you please just merge this into my last Makefile fix?

 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 7506ed4..40cb676 100644
--- a/Makefile
+++ b/Makefile
@@ -52,7 +52,7 @@ ifneq ($(BUILDDIR),$(CURDIR))
 endif
 endif
 endif
-	# findutils v4.1.x (RHEL 4) do not have '+' syntax
+# findutils v4.1.x (RHEL 4) do not have '+' syntax
 	@if test -d "$(BUILDDIR)/"; then \
 		$(CLEAN_FIND) -exec rm -f {} + 2> /dev/null || \
 		$(CLEAN_FIND) -exec rm -f {} \; ; \

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH (mtd-utils)] Makefile: fixup previous 'make clean' fix
  2012-03-28 23:59 [PATCH (mtd-utils)] Makefile: fixup previous 'make clean' fix Brian Norris
@ 2012-03-29  3:30 ` Mike Frysinger
  2012-04-02  8:10 ` Artem Bityutskiy
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2012-03-29  3:30 UTC (permalink / raw)
  To: Brian Norris; +Cc: linux-mtd, Artem Bityutskiy

On Wed, Mar 28, 2012 at 19:59, Brian Norris <computersforpeace@gmail.com> wrote:
> Apparently, Makefile comments need to be made without indentation. Otherwise,
> they are printed out as shell commands. This fix prevents seeing this in your
> shell during 'make clean':

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH (mtd-utils)] Makefile: fixup previous 'make clean' fix
  2012-03-28 23:59 [PATCH (mtd-utils)] Makefile: fixup previous 'make clean' fix Brian Norris
  2012-03-29  3:30 ` Mike Frysinger
@ 2012-04-02  8:10 ` Artem Bityutskiy
  1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2012-04-02  8:10 UTC (permalink / raw)
  To: Brian Norris; +Cc: linux-mtd, Mike Frysinger

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

On Wed, 2012-03-28 at 16:59 -0700, Brian Norris wrote:
> Apparently, Makefile comments need to be made without indentation. Otherwise,
> they are printed out as shell commands. This fix prevents seeing this in your
> shell during 'make clean':

Pushed to mtd-utils.git, thanks!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-02  8:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-28 23:59 [PATCH (mtd-utils)] Makefile: fixup previous 'make clean' fix Brian Norris
2012-03-29  3:30 ` Mike Frysinger
2012-04-02  8:10 ` Artem Bityutskiy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox