* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
@ 2012-04-16 22:20 ` Paul Gortmaker
2012-04-17 1:25 ` Randy Dunlap
2012-04-25 11:05 ` Artem Bityutskiy
2012-04-25 15:33 ` Artem Bityutskiy
2 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2012-04-16 22:20 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Tim Hockin, LKML, linux-next, linux-mtd,
Andrew Morton, David Woodhouse
On Mon, Apr 16, 2012 at 3:50 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
Minor nit -- above line and subject reference sbc2, when fail comes
from scb2 source module.
Paul.
--
> is not enabled, so make it depend on PCI.
>
> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: linux-mtd@lists.infradead.org
> ---
> drivers/mtd/maps/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
> +++ linux-next-20120416/drivers/mtd/maps/Kconfig
> @@ -224,7 +224,7 @@ config MTD_CK804XROM
>
> config MTD_SCB2_FLASH
> tristate "BIOS flash chip on Intel SCB2 boards"
> - depends on X86 && MTD_JEDECPROBE
> + depends on X86 && MTD_JEDECPROBE && PCI
> help
> Support for treating the BIOS flash chip on Intel SCB2 boards
> as an MTD device - with this you can reprogram your BIOS.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 22:20 ` Paul Gortmaker
@ 2012-04-17 1:25 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2012-04-17 1:25 UTC (permalink / raw)
To: Paul Gortmaker
Cc: Stephen Rothwell, Tim Hockin, LKML, linux-next, linux-mtd,
Andrew Morton, David Woodhouse
On 04/16/2012 03:20 PM, Paul Gortmaker wrote:
> On Mon, Apr 16, 2012 at 3:50 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> From: Randy Dunlap <rdunlap@xenotime.net>
>>
>> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
>
> Minor nit -- above line and subject reference sbc2, when fail comes
> from scb2 source module.
Ack. I noticed later that I had botched that.
Thanks.
> Paul.
> --
>
>> is not enabled, so make it depend on PCI.
>>
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
>> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>>
>> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
>> Cc: David Woodhouse <dwmw2@infradead.org>
>> Cc: linux-mtd@lists.infradead.org
>> ---
>> drivers/mtd/maps/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
>> +++ linux-next-20120416/drivers/mtd/maps/Kconfig
>> @@ -224,7 +224,7 @@ config MTD_CK804XROM
>>
>> config MTD_SCB2_FLASH
>> tristate "BIOS flash chip on Intel SCB2 boards"
>> - depends on X86 && MTD_JEDECPROBE
>> + depends on X86 && MTD_JEDECPROBE && PCI
>> help
>> Support for treating the BIOS flash chip on Intel SCB2 boards
>> as an MTD device - with this you can reprogram your BIOS.
>> --
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
2012-04-16 22:20 ` Paul Gortmaker
@ 2012-04-25 11:05 ` Artem Bityutskiy
2012-04-25 15:33 ` Artem Bityutskiy
2 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2012-04-25 11:05 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Tim Hockin, LKML, linux-next, linux-mtd,
Andrew Morton, David Woodhouse
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
On Mon, 2012-04-16 at 12:50 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
> is not enabled, so make it depend on PCI.
>
> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
2012-04-16 19:50 ` [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled Randy Dunlap
2012-04-16 22:20 ` Paul Gortmaker
2012-04-25 11:05 ` Artem Bityutskiy
@ 2012-04-25 15:33 ` Artem Bityutskiy
2 siblings, 0 replies; 5+ messages in thread
From: Artem Bityutskiy @ 2012-04-25 15:33 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Tim Hockin, LKML, linux-next, linux-mtd,
Andrew Morton, David Woodhouse
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Mon, 2012-04-16 at 12:50 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
> is not enabled, so make it depend on PCI.
>
> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread