public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Atlant Schmidt <aschmidt@dekaresearch.com>
Cc: "'linux-mtd@lists.infradead.org'" <linux-mtd@lists.infradead.org>,
	Cale Surgen <csurgen@dekaresearch.com>
Subject: Re: Does UBI still place a just-tortured block first in the free block list?
Date: Tue, 01 Jul 2014 17:53:24 +0300	[thread overview]
Message-ID: <1404226404.6841.120.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <0A40042D85E7C84DB443060EC44B3FD36D986A2F0A@dekaexchange07.deka.local>

Hi Atlant,

On Tue, 2014-07-01 at 09:11 -0400, Atlant Schmidt wrote:
> Folks:
> 
>   Several years ago, the behavior of UBI was that if a block
>   failed to write, UBI would torture-test the block (with 0x5A
>   and 0xA5 patterns) and if the block passed the torture test,
>   it would be placed at the top of the list of available blocks.

Not sure, eraseblocks are stored in an RB-tree tree which is indexed by
the erase counter. Then UBI picks those with smaller erase counters
first.

>   With this algorithm, UBI would attempt to again use the just-
>   tortured block for the data that was still waiting to be written.
>   But because the write failures were often data-dependent, in
>   our experience, the block would frequently again fail to store
>   the data to be written. It would be tortured again, passed again,
>   and the cycle would repeat. We've seen this cycle continue for
>   minutes at a time.

Sounds like a possible scenario, if the PEB in question has low erase
counter.

>   Is the algorithm still the same? Or is the just-tortured block
>   now placed at the bottom of the list of available blocks so that
>   it will only show up again later (when the data to be written
>   will probably be different)?

I am not sure about the list you are talking about, do you just assume
there is a list or you mean a specific list?

I do not think this part of UBI changed for the last several years.

-- 
Best Regards,
Artem Bityutskiy

  parent reply	other threads:[~2014-07-01 14:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 13:11 Does UBI still place a just-tortured block first in the free block list? Atlant Schmidt
2014-07-01 13:40 ` Richard Weinberger
2014-07-01 14:53 ` Artem Bityutskiy [this message]
2014-07-01 15:02   ` Atlant Schmidt
2014-07-01 15:14     ` Artem Bityutskiy
2014-07-01 15:27       ` Atlant Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404226404.6841.120.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=aschmidt@dekaresearch.com \
    --cc=csurgen@dekaresearch.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox