From: Artem Bityutskiy <dedekind1@gmail.com>
To: Atlant Schmidt <aschmidt@dekaresearch.com>
Cc: "'linux-mtd@lists.infradead.org'" <linux-mtd@lists.infradead.org>,
Cale Surgen <csurgen@dekaresearch.com>
Subject: Re: Does UBI still place a just-tortured block first in the free block list?
Date: Tue, 01 Jul 2014 18:14:53 +0300 [thread overview]
Message-ID: <1404227693.6841.129.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <0A40042D85E7C84DB443060EC44B3FD36D986A2F0B@dekaexchange07.deka.local>
On Tue, 2014-07-01 at 11:02 -0400, Atlant Schmidt wrote:
> I guess I'll go find that tree and see how we might
> change things so that a different block would win
> the next election. Any suggestions?
What you say sounds like the problem is not in the PEB selection
algorithm. The problem is in the "bad/good" criteria that we use.
What you say is that currently UBI is unable to reliably tell whether a
PEB is good or bad. And instead of just marking a PEB as bad, we keep
try to re-use it.
If I got it right, then I'd suggest 2 solutions.
1. Improve the 'torture' function and make it work for your case. It
would not solve the problem in general, but would solve your problem.
2. Try to detect situations when a PEB is tortured "too often". I am not
sure how to do this reliably, though, but may be you can invent
something. I guess the right way is to introduce a counter and store it
in the EC header. We have plenty of unused space there.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2014-07-01 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 13:11 Does UBI still place a just-tortured block first in the free block list? Atlant Schmidt
2014-07-01 13:40 ` Richard Weinberger
2014-07-01 14:53 ` Artem Bityutskiy
2014-07-01 15:02 ` Atlant Schmidt
2014-07-01 15:14 ` Artem Bityutskiy [this message]
2014-07-01 15:27 ` Atlant Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404227693.6841.129.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=aschmidt@dekaresearch.com \
--cc=csurgen@dekaresearch.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox