[PATCH v3 0/2] Add a "label" property to the mtd device

[PATCH v3 0/2] Add a "label" property to the mtd device

[Cédric Le Goater]

Hello,

Herer are a couple of patches adding a "label" property to the mtd
device, which can be used to identify a specific chip on a system with
multiple chips. This is common on the OpenPower boards, there can be
four chips holding the firmware for the BMC and the firmware for the
host, plus chips with golden images for recovery.

Thanks,

C.

 Changes since v2:

 - only assign device name from label if mtd->name is undefined

 Changes since v1:

 - moved the use of the "label" property from mtd_set_dev_defaults()
   to mtd_set_of_node() to let drivers keep control on how mtd->name
   is set and allocated.

Cédric Le Goater (2):
  mtd: name the mtd device with an optional label property
  dt-bindings: mtd: add a common label property to all mtd devices

 Documentation/devicetree/bindings/mtd/common.txt | 15 +++++++++++++++
 include/linux/mtd/mtd.h                          |  3 +++
 2 files changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/common.txt

-- 
2.7.4

[PATCH v3 1/2] mtd: name the mtd device with an optional label property

[Cédric Le Goater]

This can be used to easily identify a specific chip on a system with
multiple chips.

Suggested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---

 Changes since v2:

 - only assign device name from label if mtd->name is undefined

 Changes since v1:

 - moved the use of the "label" property from mtd_set_dev_defaults()
   to mtd_set_of_node() to let drivers keep control on how mtd->name
   is set and allocated.

 include/linux/mtd/mtd.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 13f8052b9ff9..5a08ddff4f51 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -24,6 +24,7 @@
 #include <linux/uio.h>
 #include <linux/notifier.h>
 #include <linux/device.h>
+#include <linux/of.h>
 
 #include <mtd/mtd-abi.h>
 
@@ -385,6 +386,8 @@ static inline void mtd_set_of_node(struct mtd_info *mtd,
 				   struct device_node *np)
 {
 	mtd->dev.of_node = np;
+	if (!mtd->name)
+		of_property_read_string(np, "label", &mtd->name);
 }
 
 static inline struct device_node *mtd_get_of_node(struct mtd_info *mtd)
-- 
2.7.4

[PATCH v3 2/2] dt-bindings: mtd: add a common label property to all mtd devices

[Cédric Le Goater]

This can be used to easily identify a specific chip on a system with
multiple chips.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/mtd/common.txt | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/common.txt

diff --git a/Documentation/devicetree/bindings/mtd/common.txt b/Documentation/devicetree/bindings/mtd/common.txt
new file mode 100644
index 000000000000..fc068b923d7a
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/common.txt
@@ -0,0 +1,15 @@
+* Common properties of all MTD devices
+
+Optional properties:
+- label: user-defined MTD device name. Can be used to assign user
+  friendly names to MTD devices (instead of the flash model or flash
+  controller based name) in order to ease flash device identification
+  and/or describe what they are used for.
+
+Example:
+
+	flash@0 {
+		label = "System-firmware";
+
+		/* flash type specific properties */
+	};
-- 
2.7.4

Re: [PATCH v3 0/2] Add a "label" property to the mtd device

[Marek Vasut]

On 02/09/2017 10:21 AM, Cédric Le Goater wrote:
> Hello,
> 
> Herer are a couple of patches adding a "label" property to the mtd
> device, which can be used to identify a specific chip on a system with
> multiple chips. This is common on the OpenPower boards, there can be
> four chips holding the firmware for the BMC and the firmware for the
> host, plus chips with golden images for recovery.

Series is
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

> Thanks,
> 
> C.
> 
>  Changes since v2:
> 
>  - only assign device name from label if mtd->name is undefined
> 
>  Changes since v1:
> 
>  - moved the use of the "label" property from mtd_set_dev_defaults()
>    to mtd_set_of_node() to let drivers keep control on how mtd->name
>    is set and allocated.
> 
> Cédric Le Goater (2):
>   mtd: name the mtd device with an optional label property
>   dt-bindings: mtd: add a common label property to all mtd devices
> 
>  Documentation/devicetree/bindings/mtd/common.txt | 15 +++++++++++++++
>  include/linux/mtd/mtd.h                          |  3 +++
>  2 files changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/common.txt
> 


-- 
Best regards,
Marek Vasut

Re: [PATCH v3 0/2] Add a "label" property to the mtd device

[Brian Norris]

On Thu, Feb 09, 2017 at 09:25:32PM +0100, Marek Vasut wrote:
> On 02/09/2017 10:21 AM, Cédric Le Goater wrote:
> > Hello,
> > 
> > Herer are a couple of patches adding a "label" property to the mtd
> > device, which can be used to identify a specific chip on a system with
> > multiple chips. This is common on the OpenPower boards, there can be
> > four chips holding the firmware for the BMC and the firmware for the
> > host, plus chips with golden images for recovery.
> 
> Series is
> Reviewed-by: Marek Vasut <marek.vasut@gmail.com>

Applied to l2-mtd.git.