* mtd: nand: use dma_mapping_error to check map errors
@ 2017-08-08 14:35 Pan Bian
2017-08-13 7:56 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2017-08-08 14:35 UTC (permalink / raw)
To: Boris Brezillon, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen
Cc: linux-mtd, linux-kernel, Pan Bian
The return value of dma_map_single() should be checked by
dma_mapping_error(). However, in function flctl_dma_fifo0_transfer(), its
return value is checked against NULL, which could result in failures.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/mtd/nand/sh_flctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index 891ac7b..2404d66 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -411,7 +411,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,
dma_addr = dma_map_single(chan->device->dev, buf, len, dir);
- if (dma_addr)
+ if (!dma_mapping_error(chan->device->dev, dma_addr))
desc = dmaengine_prep_slave_single(chan, dma_addr, len,
tr_dir, DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: mtd: nand: use dma_mapping_error to check map errors
2017-08-08 14:35 mtd: nand: use dma_mapping_error to check map errors Pan Bian
@ 2017-08-13 7:56 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2017-08-13 7:56 UTC (permalink / raw)
To: Pan Bian
Cc: Richard Weinberger, David Woodhouse, Brian Norris, Marek Vasut,
Cyrille Pitchen, linux-mtd, linux-kernel
Le Tue, 8 Aug 2017 22:35:42 +0800,
Pan Bian <bianpan2016@163.com> a écrit :
> The return value of dma_map_single() should be checked by
> dma_mapping_error(). However, in function flctl_dma_fifo0_transfer(), its
> return value is checked against NULL, which could result in failures.
Applied, thanks.
Boris
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
> drivers/mtd/nand/sh_flctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
> index 891ac7b..2404d66 100644
> --- a/drivers/mtd/nand/sh_flctl.c
> +++ b/drivers/mtd/nand/sh_flctl.c
> @@ -411,7 +411,7 @@ static int flctl_dma_fifo0_transfer(struct sh_flctl *flctl, unsigned long *buf,
>
> dma_addr = dma_map_single(chan->device->dev, buf, len, dir);
>
> - if (dma_addr)
> + if (!dma_mapping_error(chan->device->dev, dma_addr))
> desc = dmaengine_prep_slave_single(chan, dma_addr, len,
> tr_dir, DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-13 7:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-08 14:35 mtd: nand: use dma_mapping_error to check map errors Pan Bian
2017-08-13 7:56 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox