From: Vignesh Raghavendra <vigneshr@ti.com>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] mtd: cfi_cmdset_0002: Use status register where possible
Date: Thu, 5 Nov 2020 21:34:32 +0530 [thread overview]
Message-ID: <1af99b7d-e388-3c41-a8d8-9f82067ae857@ti.com> (raw)
In-Reply-To: <2198bd20e69be374f7533f45118c98750eb5362a.camel@infinera.com>
On 11/4/20 3:23 PM, Joakim Tjernlund wrote:
> On Wed, 2020-11-04 at 11:12 +0530, Vignesh Raghavendra wrote:
>> Hi Joakim
>>
>> On 10/31/20 4:56 PM, Joakim Tjernlund wrote:
>>> On Fri, 2020-10-30 at 19:52 +0100, Miquel Raynal wrote:
>>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
>>>>
>>>>
[...]
>> commit 4844ef80305d ("mtd: cfi_cmdset_0002: Add support for polling
>> status register") was added in 5.3 and therefore is part of 5.4. But
>> note that this is a "new feature" and therefore won't be backported to
>> kernels older than 5.3.
>
> Oh, my memory is off then, sorry.
>
>> Similarly, this patch (when accepted) is not a candidate for stable
>> kernel backports because the intention of enabling polling status
>> register for Write Completion is to enable flashes that "don't" support
>> DQ polling at all (mainly HyperFlash).
>> Enabling this for all flashes that support the feature is not a bug fix
>> IMO. Also, there isn't enough testing to prove that feature works for
>> all CFI NOR flashes on all platforms and therefore would be risky to be
>> backported to stable kernels.
>
> This is 2 things,
> 1. making it possible to use Hyper flash (HW enablement)
> 2. improving the flash driver to function more precise(getting an accurate error rather than a TMO) for most AMD flashes.
>
> 1. happens on a regular basis in stable.
> 2. can be discussed for stable but should at least go into master now that status has been in there for a while
>
Yes, but my objection is that there has not been enough testing to prove
that its safe to backport to stable kernels and there is nothing that's
broken in older kernels which this patch fixes.
Regards
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-11-05 16:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 15:45 [PATCH] mtd: cfi_cmdset_0002: Use status register where possible Joakim Tjernlund
2020-10-30 17:47 ` Miquel Raynal
2020-10-30 18:39 ` Joakim Tjernlund
2020-10-30 18:52 ` Miquel Raynal
2020-10-31 11:26 ` Joakim Tjernlund
2020-11-04 5:42 ` Vignesh Raghavendra
2020-11-04 9:53 ` Joakim Tjernlund
2020-11-05 16:04 ` Vignesh Raghavendra [this message]
2020-11-05 16:44 ` Joakim Tjernlund
2020-11-05 15:57 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1af99b7d-e388-3c41-a8d8-9f82067ae857@ti.com \
--to=vigneshr@ti.com \
--cc=Joakim.Tjernlund@infinera.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox