Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: "linux-mtd @ lists . infradead . org"
	<linux-mtd@lists.infradead.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH] mtd: cfi_cmdset_0002: Use status register where possible
Date: Fri, 30 Oct 2020 18:47:36 +0100	[thread overview]
Message-ID: <20201030184736.4ec434f5@xps13> (raw)
In-Reply-To: <20201022154506.17639-1-joakim.tjernlund@infinera.com>

Hi Joakim,

Please Cc the MTD maintainers, not only the list (get_maintainers.pl).

Joakim Tjernlund <joakim.tjernlund@infinera.com> wrote on Thu, 22 Oct
2020 17:45:06 +0200:

> Commit "mtd: cfi_cmdset_0002: Add support for polling status register"
> added support for polling the status rather than using DQ polling.
> However, status register is used only when DQ polling is missing.
> Lets use status register when available as it is superior to DQ polling.
> 

I will let vignesh comment about the content (looks fine by me) but you will
need a Fixes tag here.

> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Cc: stable@vger.kernel.org
> ---
>  drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
> index a1f3e1031c3d..ee9b322e63bb 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -117,7 +117,7 @@ static struct mtd_chip_driver cfi_amdstd_chipdrv = {
>  static int cfi_use_status_reg(struct cfi_private *cfi)
>  {
>  	struct cfi_pri_amdstd *extp = cfi->cmdset_priv;
> -	u8 poll_mask = CFI_POLL_STATUS_REG | CFI_POLL_DQ;
> +	u8 poll_mask = CFI_POLL_STATUS_REG;
>  
>  	return extp->MinorVersion >= '5' &&
>  		(extp->SoftwareFeatures & poll_mask) == CFI_POLL_STATUS_REG;

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-10-30 17:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 15:45 [PATCH] mtd: cfi_cmdset_0002: Use status register where possible Joakim Tjernlund
2020-10-30 17:47 ` Miquel Raynal [this message]
2020-10-30 18:39   ` Joakim Tjernlund
2020-10-30 18:52     ` Miquel Raynal
2020-10-31 11:26       ` Joakim Tjernlund
2020-11-04  5:42         ` Vignesh Raghavendra
2020-11-04  9:53           ` Joakim Tjernlund
2020-11-05 16:04             ` Vignesh Raghavendra
2020-11-05 16:44               ` Joakim Tjernlund
2020-11-05 15:57 ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030184736.4ec434f5@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=joakim.tjernlund@infinera.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox