* [PATCH] mtd: omap2: use nand_base defaults for polled I/O
@ 2013-12-17 9:36 Brian Norris
2014-01-03 6:49 ` Gupta, Pekon
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2013-12-17 9:36 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Pekon Gupta, Ezequiel Garcia
The omap_{read,write}_buf{8,16}() functions are identical to the default
nand_base versions. Just let nand_base assign them in the
NAND_OMAP_POLLED case.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
Compile tested only
drivers/mtd/nand/omap2.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index e9e2c37c0a80..eadc76a57f45 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1730,13 +1730,7 @@ static int omap_nand_probe(struct platform_device *pdev)
break;
case NAND_OMAP_POLLED:
- if (nand_chip->options & NAND_BUSWIDTH_16) {
- nand_chip->read_buf = omap_read_buf16;
- nand_chip->write_buf = omap_write_buf16;
- } else {
- nand_chip->read_buf = omap_read_buf8;
- nand_chip->write_buf = omap_write_buf8;
- }
+ /* Use nand_base defaults for {read,write}_buf */
break;
case NAND_OMAP_PREFETCH_DMA:
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] mtd: omap2: use nand_base defaults for polled I/O
2013-12-17 9:36 [PATCH] mtd: omap2: use nand_base defaults for polled I/O Brian Norris
@ 2014-01-03 6:49 ` Gupta, Pekon
2014-01-03 19:39 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Gupta, Pekon @ 2014-01-03 6:49 UTC (permalink / raw)
To: Brian Norris, linux-mtd@lists.infradead.org; +Cc: Ezequiel Garcia
>From: Brian Norris [mailto:computersforpeace@gmail.com]
>
>The omap_{read,write}_buf{8,16}() functions are identical to the default
>nand_base versions. Just let nand_base assign them in the
>NAND_OMAP_POLLED case.
>
>Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>---
>Compile tested only
>
> drivers/mtd/nand/omap2.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>index e9e2c37c0a80..eadc76a57f45 100644
>--- a/drivers/mtd/nand/omap2.c
>+++ b/drivers/mtd/nand/omap2.c
>@@ -1730,13 +1730,7 @@ static int omap_nand_probe(struct platform_device *pdev)
> break;
>
> case NAND_OMAP_POLLED:
>- if (nand_chip->options & NAND_BUSWIDTH_16) {
>- nand_chip->read_buf = omap_read_buf16;
>- nand_chip->write_buf = omap_write_buf16;
>- } else {
>- nand_chip->read_buf = omap_read_buf8;
>- nand_chip->write_buf = omap_write_buf8;
>- }
>+ /* Use nand_base defaults for {read,write}_buf */
> break;
>
> case NAND_OMAP_PREFETCH_DMA:
>--
>1.8.3.2
Tested-by: Pekon Gupta <pekon@ti.com>
with regards, pekon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: omap2: use nand_base defaults for polled I/O
2014-01-03 6:49 ` Gupta, Pekon
@ 2014-01-03 19:39 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2014-01-03 19:39 UTC (permalink / raw)
To: Gupta, Pekon; +Cc: linux-mtd@lists.infradead.org, Ezequiel Garcia
On Fri, Jan 03, 2014 at 06:49:51AM +0000, Pekon Gupta wrote:
> >From: Brian Norris [mailto:computersforpeace@gmail.com]
> >
> >The omap_{read,write}_buf{8,16}() functions are identical to the default
> >nand_base versions. Just let nand_base assign them in the
> >NAND_OMAP_POLLED case.
> >
> >Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> >---
> >Compile tested only
>
> Tested-by: Pekon Gupta <pekon@ti.com>
Thanks.
Pushed to l2-mtd.git.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-03 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 9:36 [PATCH] mtd: omap2: use nand_base defaults for polled I/O Brian Norris
2014-01-03 6:49 ` Gupta, Pekon
2014-01-03 19:39 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox