From: Marek Vasut <marex@denx.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: m25p80: assign default read command
Date: Sat, 18 Jan 2014 19:54:40 +0100 [thread overview]
Message-ID: <201401181954.40539.marex@denx.de> (raw)
In-Reply-To: <1389906547-31959-1-git-send-email-computersforpeace@gmail.com>
On Thursday, January 16, 2014 at 10:09:07 PM, Brian Norris wrote:
> In the following commit (in -next):
>
> commit 8552b439aba7f32063755d23f79ca27b4d0a3115
> drivers: mtd: m25p80: convert "bool" read check into an enum
>
> We converted the boolean 'fast_read' property to become an enum
> 'flash_read', but at the same time, we changed the conditional path so
> that it doesn't choose a default value in some cases (technically, we
> choose the correct default simply by virtue of devm_kzalloc(), which
> zeroes this out to be a NORMAL read operation, but still...).
Yep, that's true. It did default to the correct _NORMAL.
> Fix this by setting a default for the 'else' clause.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Sourav Poddar <sourav.poddar@ti.com>
Let's be explicit indeed.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-01-18 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 21:09 [PATCH] mtd: m25p80: assign default read command Brian Norris
2014-01-18 18:54 ` Marek Vasut [this message]
2014-01-20 19:51 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401181954.40539.marex@denx.de \
--to=marex@denx.de \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox