* [PATCH] mtd:elm: Use correct check on return value of pm_runtime_get_sync
@ 2014-02-03 14:54 Stefan Sørensen
2014-02-11 18:45 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Sørensen @ 2014-02-03 14:54 UTC (permalink / raw)
To: dwmw2, computersforpeace, avinashphilip, linux-mtd; +Cc: Stefan Sørensen
The ELM driver incorrectly reagard any non-zero return value from
pm_runtime_get_sync as an error, but it may return 1 if the device
was already active. Fix to only error when return value is negative.
Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
---
drivers/mtd/devices/elm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index d1dd6a3..e2c073c 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -380,7 +380,7 @@ static int elm_probe(struct platform_device *pdev)
}
pm_runtime_enable(&pdev->dev);
- if (pm_runtime_get_sync(&pdev->dev)) {
+ if (pm_runtime_get_sync(&pdev->dev) < 0) {
ret = -EINVAL;
pm_runtime_disable(&pdev->dev);
dev_err(&pdev->dev, "can't enable clock\n");
--
1.8.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-11 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-03 14:54 [PATCH] mtd:elm: Use correct check on return value of pm_runtime_get_sync Stefan Sørensen
2014-02-11 18:45 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox