From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: linux-mtd@lists.infradead.org
Cc: Grant Likely <grant.likely@secretlab.ca>,
Brian Norris <computersforpeace@gmail.com>,
Boris BREZILLON <b.brezillon.dev@gmail.com>
Subject: Re: [PATCH v3 0/2] Add NAND ECC devicetree binding
Date: Fri, 28 Feb 2014 11:59:24 -0300 [thread overview]
Message-ID: <20140228145923.GB24805@localhost> (raw)
In-Reply-To: <1393280689-24267-1-git-send-email-ezequiel.garcia@free-electrons.com>
On Mon, Feb 24, 2014 at 07:24:47PM -0300, Ezequiel Garcia wrote:
> Third round, fixing a stupid semi-colon miss.
>
> NAND controllers have special ECC modes, raising per-driver ECC mode devicetree
> binding. See for instance the binding for OMAP:
>
> - ti,nand-ecc-opt: A string setting the ECC layout to use. One of:
> "sw" <deprecated> use "ham1" instead
> "hw" <deprecated> use "ham1" instead
> "hw-romcode" <deprecated> use "ham1" instead
> "ham1" 1-bit Hamming ecc code
> "bch4" 4-bit BCH ecc code
> "bch8" 8-bit BCH ecc code
>
> Other drivers (such as pxa3xx-nand) have similar requirements, with special
> (controller-specific) ECC modes. Instead of adding a possibly different
> binding per compatible-string, let's add generic ECC strength and ECC step size.
>
> This properties aim at providing a complete description of the required ECC
> correction to let drivers choose the appropriate ECC mode.
>
> Changes from v2:
>
> * Added a missing semi-colon.
>
> Changes from v1:
>
> * Improve the binding documentation, as per Brian Norris' suggestions.
>
> * Added the helper functions.
>
> Ezequiel Garcia (2):
> of_mtd: Add helpers to get ECC strength and ECC step size
> mtd: nand: Add a devicetree binding for ECC strength and ECC step size
>
> Documentation/devicetree/bindings/mtd/nand.txt | 14 +++++++++++
> drivers/of/of_mtd.c | 34 ++++++++++++++++++++++++++
> include/linux/of_mtd.h | 12 +++++++++
> 3 files changed, 60 insertions(+)
>
Brian? Any chance this lands on v3.15?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-28 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 22:24 [PATCH v3 0/2] Add NAND ECC devicetree binding Ezequiel Garcia
2014-02-24 22:24 ` [PATCH v3 1/2] of_mtd: Add helpers to get ECC strength and ECC step size Ezequiel Garcia
2014-02-24 22:24 ` [PATCH v3 2/2] mtd: nand: Add a devicetree binding for " Ezequiel Garcia
2014-02-28 14:59 ` Ezequiel Garcia [this message]
2014-03-05 8:20 ` [PATCH v3 0/2] Add NAND ECC devicetree binding Brian Norris
2014-03-04 10:45 ` Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228145923.GB24805@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=b.brezillon.dev@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox