* [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH
@ 2014-03-11 4:31 Erico Nunes
2014-03-11 8:39 ` Lee Jones
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Erico Nunes @ 2014-03-11 4:31 UTC (permalink / raw)
To: dwmw2
Cc: artem.bityutskiy, linux-kernel, b32955, linux-mtd,
computersforpeace, Erico Nunes
Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
doesn't match the exact name of the configuration option.
This warning showed up once to me when I was starting to set up BCH. After
checking my .config file, it took a moment before realizing it is
CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
drivers/mtd/nand/nand_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 9715a7b..5a93787 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -3825,7 +3825,7 @@ int nand_scan_tail(struct mtd_info *mtd)
case NAND_ECC_SOFT_BCH:
if (!mtd_nand_has_bch()) {
- pr_warn("CONFIG_MTD_ECC_BCH not enabled\n");
+ pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n");
BUG();
}
ecc->calculate = nand_bch_calculate_ecc;
--
1.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH
2014-03-11 4:31 [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH Erico Nunes
@ 2014-03-11 8:39 ` Lee Jones
2014-03-25 22:28 ` Erico Nunes
2014-03-26 7:34 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2014-03-11 8:39 UTC (permalink / raw)
To: Erico Nunes
Cc: artem.bityutskiy, linux-kernel, b32955, linux-mtd,
computersforpeace, dwmw2
> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
> doesn't match the exact name of the configuration option.
> This warning showed up once to me when I was starting to set up BCH. After
> checking my .config file, it took a moment before realizing it is
> CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
> drivers/mtd/nand/nand_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 9715a7b..5a93787 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3825,7 +3825,7 @@ int nand_scan_tail(struct mtd_info *mtd)
>
> case NAND_ECC_SOFT_BCH:
> if (!mtd_nand_has_bch()) {
> - pr_warn("CONFIG_MTD_ECC_BCH not enabled\n");
> + pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n");
> BUG();
> }
> ecc->calculate = nand_bch_calculate_ecc;
Not sure if CONFIG options should be printed in the log at all, but
the correct option is better than an incorrect one. Seeing as
CONFIG_MTD_ECC_BCH doesn't actually exist:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH
2014-03-11 4:31 [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH Erico Nunes
2014-03-11 8:39 ` Lee Jones
@ 2014-03-25 22:28 ` Erico Nunes
2014-03-26 7:34 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Erico Nunes @ 2014-03-25 22:28 UTC (permalink / raw)
To: David Woodhouse
Cc: artem.bityutskiy, linux-kernel, b32955, linux-mtd, Brian Norris,
Erico Nunes
2014-03-11 1:31 GMT-03:00 Erico Nunes <nunes.erico@gmail.com>:
> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
> doesn't match the exact name of the configuration option.
> This warning showed up once to me when I was starting to set up BCH. After
> checking my .config file, it took a moment before realizing it is
> CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
> drivers/mtd/nand/nand_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 9715a7b..5a93787 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -3825,7 +3825,7 @@ int nand_scan_tail(struct mtd_info *mtd)
>
> case NAND_ECC_SOFT_BCH:
> if (!mtd_nand_has_bch()) {
> - pr_warn("CONFIG_MTD_ECC_BCH not enabled\n");
> + pr_warn("CONFIG_MTD_NAND_ECC_BCH not enabled\n");
> BUG();
> }
> ecc->calculate = nand_bch_calculate_ecc;
> --
> 1.9.0
>
Ping.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH
2014-03-11 4:31 [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH Erico Nunes
2014-03-11 8:39 ` Lee Jones
2014-03-25 22:28 ` Erico Nunes
@ 2014-03-26 7:34 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2014-03-26 7:34 UTC (permalink / raw)
To: Erico Nunes; +Cc: b32955, dwmw2, linux-kernel, linux-mtd, artem.bityutskiy
On Tue, Mar 11, 2014 at 01:31:26AM -0300, Erico Nunes wrote:
> Mention to CONFIG_MTD_ECC_BCH in the warning message can be confusing as this
> doesn't match the exact name of the configuration option.
> This warning showed up once to me when I was starting to set up BCH. After
> checking my .config file, it took a moment before realizing it is
> CONFIG_MTD_NAND_ECC_BCH instead of CONFIG_MTD_ECC_BCH.
>
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-26 7:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-11 4:31 [PATCH] mtd: nand: fix mention to CONFIG_MTD_NAND_ECC_BCH Erico Nunes
2014-03-11 8:39 ` Lee Jones
2014-03-25 22:28 ` Erico Nunes
2014-03-26 7:34 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox