From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Lior Amsalem <alior@marvell.com>,
devicetree@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Jason Cooper <jason@lakedaemon.net>,
Tawfik Bayouk <tawfik@marvell.com>, Andrew Lunn <andrew@lunn.ch>,
Seif Mazareeb <seif@marvell.com>,
linux-mtd@lists.infradead.org,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Gregory Clement <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2 3/6] ARM: mvebu: Add the Core Divider clock to Armada 38x SoCs
Date: Thu, 13 Mar 2014 17:05:46 -0300 [thread overview]
Message-ID: <20140313200546.GB30590@arch.cereza> (raw)
In-Reply-To: <53221B41.2030001@cogentembedded.com>
On Mar 13, Sergei Shtylyov wrote:
> Hello.
>
> On 03/13/2014 10:38 PM, Ezequiel Garcia wrote:
>
> >From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> >The Armada 38x SoC family has a clock provider called "Core Divider",
> >derived from the fixed 2 GHz main PLL clock. This is similar to the
> >one on A370, A375 and AXP.
>
> >Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> >---
> > arch/arm/boot/dts/armada-38x.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
>
> >diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> >index 38fc3a0..76cc27e 100644
> >--- a/arch/arm/boot/dts/armada-38x.dtsi
> >+++ b/arch/arm/boot/dts/armada-38x.dtsi
> >@@ -337,6 +337,14 @@
> > compatible = "marvell,orion-mdio";
> > reg = <0x72004 0x4>;
> > };
> >+
> >+ coredivclk: corediv-clock@e4250 {
>
> I would suggest naming the device just "clock@e4250" on the same grounds
> of having the generic device names.
>
Right, I overlooked this.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-13 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 19:38 [PATCH v2 0/6] Armada 380 NAND support Ezequiel Garcia
2014-03-13 19:38 ` [PATCH v2 1/6] clk: mvebu: Support Armada 380 SoC on the core divider clock Ezequiel Garcia
2014-03-13 19:38 ` [PATCH v2 2/6] ARM: mvebu: Add a 2 GHz fixed-clock on Armada 38x SoCs Ezequiel Garcia
2014-03-13 19:38 ` [PATCH v2 3/6] ARM: mvebu: Add the Core Divider clock to " Ezequiel Garcia
2014-03-13 20:55 ` Sergei Shtylyov
2014-03-13 20:05 ` Ezequiel Garcia [this message]
2014-03-13 19:39 ` [PATCH v2 4/6] ARM: mvebu: Add support for NAND controller in Armada 38x SoC Ezequiel Garcia
2014-03-13 19:39 ` [PATCH v2 5/6] ARM: mvebu: Enable NAND controller in Armada 385-DB Ezequiel Garcia
2014-03-13 20:53 ` Sergei Shtylyov
2014-03-13 20:04 ` Ezequiel Garcia
2014-03-13 19:39 ` [PATCH v2 6/6] clk: mvebu: Update binding documentation for the core divider clock Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313200546.GB30590@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mturquette@linaro.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=seif@marvell.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox