* [PATCH] mtd: elm: compile suspend/resume only with PM_SLEEP
@ 2014-04-17 7:39 Wolfram Sang
2014-04-23 6:00 ` Gupta, Pekon
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2014-04-17 7:39 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, David Woodhouse, Wolfram Sang
From: Wolfram Sang <wsa@sang-engineering.com>
Fixes:
drivers/mtd/devices/elm.c:480:12: warning: 'elm_suspend' defined but not used [-Wunused-function]
drivers/mtd/devices/elm.c:488:12: warning: 'elm_resume' defined but not used [-Wunused-function]
Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
---
drivers/mtd/devices/elm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index 1fd4a0f77967..0a037b15c11b 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -418,6 +418,7 @@ static int elm_remove(struct platform_device *pdev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
/**
* elm_context_save
* saves ELM configurations to preserve them across Hardware powered-down
@@ -509,6 +510,7 @@ static int elm_resume(struct device *dev)
elm_context_restore(info);
return 0;
}
+#endif
static SIMPLE_DEV_PM_OPS(elm_pm_ops, elm_suspend, elm_resume);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] mtd: elm: compile suspend/resume only with PM_SLEEP
2014-04-17 7:39 [PATCH] mtd: elm: compile suspend/resume only with PM_SLEEP Wolfram Sang
@ 2014-04-23 6:00 ` Gupta, Pekon
2014-05-12 20:18 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Gupta, Pekon @ 2014-04-23 6:00 UTC (permalink / raw)
To: Wolfram Sang, linux-mtd@lists.infradead.org; +Cc: Brian Norris, David Woodhouse
>From: Wolfram Sang <wsa@sang-engineering.com>
>
>Fixes:
>drivers/mtd/devices/elm.c:480:12: warning: 'elm_suspend' defined but not used [-Wunused-function]
>drivers/mtd/devices/elm.c:488:12: warning: 'elm_resume' defined but not used [-Wunused-function]
>
>Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
>---
> drivers/mtd/devices/elm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
>index 1fd4a0f77967..0a037b15c11b 100644
>--- a/drivers/mtd/devices/elm.c
>+++ b/drivers/mtd/devices/elm.c
>@@ -418,6 +418,7 @@ static int elm_remove(struct platform_device *pdev)
> return 0;
> }
>
>+#ifdef CONFIG_PM_SLEEP
> /**
> * elm_context_save
> * saves ELM configurations to preserve them across Hardware powered-down
>@@ -509,6 +510,7 @@ static int elm_resume(struct device *dev)
> elm_context_restore(info);
> return 0;
> }
>+#endif
>
> static SIMPLE_DEV_PM_OPS(elm_pm_ops, elm_suspend, elm_resume);
>
>--
>1.9.1
>
Acked-by: Pekon Gupta <pekon@ti.com>
I think it's safe to mark it for stable also
CC: <stable@vger.kernel.org> # 3.12.x+
with regards, pekon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: elm: compile suspend/resume only with PM_SLEEP
2014-04-23 6:00 ` Gupta, Pekon
@ 2014-05-12 20:18 ` Brian Norris
0 siblings, 0 replies; 3+ messages in thread
From: Brian Norris @ 2014-05-12 20:18 UTC (permalink / raw)
To: Gupta, Pekon; +Cc: David Woodhouse, linux-mtd@lists.infradead.org, Wolfram Sang
On Wed, Apr 23, 2014 at 06:00:58AM +0000, Pekon Gupta wrote:
> >From: Wolfram Sang <wsa@sang-engineering.com>
> >
> >Fixes:
> >drivers/mtd/devices/elm.c:480:12: warning: 'elm_suspend' defined but not used [-Wunused-function]
> >drivers/mtd/devices/elm.c:488:12: warning: 'elm_resume' defined but not used [-Wunused-function]
> >
> >Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> >
> Acked-by: Pekon Gupta <pekon@ti.com>
Pushed to l2-mtd.git. Thanks!
> I think it's safe to mark it for stable also
> CC: <stable@vger.kernel.org> # 3.12.x+
No, build warnings are clearly clearly not candidates for -stable.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-12 20:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-17 7:39 [PATCH] mtd: elm: compile suspend/resume only with PM_SLEEP Wolfram Sang
2014-04-23 6:00 ` Gupta, Pekon
2014-05-12 20:18 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox