Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Vincenzo Aliberti <vincenzo.aliberti@gmail.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	linux-mtd@lists.infradead.org, kbuild-all@01.org
Subject: Re: [l2-mtd:master 28/29] drivers/mtd/lpddr/lpddr2_nvm.c:149:2: error: implicit declaration of function 'writel_relaxed'
Date: Wed, 21 May 2014 13:23:26 -0700	[thread overview]
Message-ID: <20140521202326.GH22233@ld-irv-0074> (raw)
In-Reply-To: <CADBu1QtQpXQTqEDBV3bzQkLmEq3s6k3rtQ2en4L7StcLszO9rQ@mail.gmail.com>

Hi Vincenzo,

Please, can you avoid top-posting?

On Wed, May 21, 2014 at 08:38:00AM +0200, Vincenzo Aliberti wrote:
> Brian,
>    considering that this memory interface is implemented only on ARM
> we can litimit the driver to ARM
> in my opinion. Is it ok for you?

I suppose. I'd really like to be able to compile test this on other
architectures (maybe by depending on COMPILE_TEST, so it still only
shows up on ARM?). But for now, adding an ARM dependency would be OK.

Are you sure that writel_relaxed() is correct here, BTW? Does your
hardware expect ordering between these register writes? If so, then you
should be using writel() instead.

> On Wed, May 21, 2014 at 3:49 AM, Brian Norris <computersforpeace@gmail.com> wrote:
> > What do you think? Should we:
> >
> >  1. Limit your driver to ARM (or other ARCH that supports
> >     writel_relaxed()?
> >  2. Use writel() instead?
> >  3. Wait for other ARCH'es to support writel_relaxed()?

Brian

  reply	other threads:[~2014-05-21 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <537bfc24.N6Jd/c3WxnkfHn37%fengguang.wu@intel.com>
2014-05-21  1:49 ` [l2-mtd:master 28/29] drivers/mtd/lpddr/lpddr2_nvm.c:149:2: error: implicit declaration of function 'writel_relaxed' Brian Norris
2014-05-21  6:38   ` Vincenzo Aliberti
2014-05-21 20:23     ` Brian Norris [this message]
2014-05-21  7:33   ` [PATCH v5] mtd: lpddr: add driver for LPDDR2-NVM PCM memories Vincenzo Aliberti
2014-05-21 20:28     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521202326.GH22233@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vincenzo.aliberti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox