Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Vincenzo Aliberti <vincenzo.aliberti@gmail.com>
Cc: fengguang.wu@intel.com, linux-mtd@lists.infradead.org,
	dedekind1@gmail.com
Subject: Re: [PATCH v5] mtd: lpddr: add driver for LPDDR2-NVM PCM memories
Date: Wed, 21 May 2014 13:28:50 -0700	[thread overview]
Message-ID: <20140521202850.GI22233@ld-irv-0074> (raw)
In-Reply-To: <1400657638-2562-1-git-send-email-vincenzo.aliberti@gmail.com>

On Wed, May 21, 2014 at 09:33:58AM +0200, Vincenzo Aliberti wrote:
> MTD: LPDDR: Add Driver for LPDDR2-NVM PCM memories
> 
> Signed-off-by: Vincenzo Aliberti <vincenzo.aliberti@gmail.com>
> 
> ---
> Changes in v5:
> 	- Add dependency from ARM architecture

I already pulled your driver into l2-mtd.git. Please base any
submissions on that branch.

> --- a/drivers/mtd/lpddr/Kconfig
> +++ b/drivers/mtd/lpddr/Kconfig
> @@ -17,4 +17,12 @@ config MTD_QINFO_PROBE
>  	    Window QINFO interface, permits software to be used for entire
>  	    families of devices. This serves similar purpose of CFI on legacy
>  	    Flash products
> +
> +config MTD_LPDDR2_NVM
> +	depends on MTD && ARM

I would note the dependency is only for writel_relaxed(), so we can fix
this up in the future, if we get support on other ARCH's.

I'll just send a patch.

> +	tristate "Support for LPDDR2-NVM flash chips"
> +	help
> +	  This option enables support of PCM memories with a LPDDR2-NVM
> +	  (Low power double data rate 2) interface.
> +
>  endmenu

Brian

      reply	other threads:[~2014-05-21 20:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <537bfc24.N6Jd/c3WxnkfHn37%fengguang.wu@intel.com>
2014-05-21  1:49 ` [l2-mtd:master 28/29] drivers/mtd/lpddr/lpddr2_nvm.c:149:2: error: implicit declaration of function 'writel_relaxed' Brian Norris
2014-05-21  6:38   ` Vincenzo Aliberti
2014-05-21 20:23     ` Brian Norris
2014-05-21  7:33   ` [PATCH v5] mtd: lpddr: add driver for LPDDR2-NVM PCM memories Vincenzo Aliberti
2014-05-21 20:28     ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140521202850.GI22233@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vincenzo.aliberti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox