* [PATCH] jffs2: compr_rubin: Remove unused function
@ 2015-01-11 16:36 Rickard Strandqvist
2015-01-12 15:56 ` Richard Weinberger
2015-01-13 4:40 ` Brian Norris
0 siblings, 2 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-11 16:36 UTC (permalink / raw)
To: David Woodhouse, linux-mtd; +Cc: linux-kernel, Rickard Strandqvist
Remove the function pulledbits() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
fs/jffs2/compr_rubin.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/jffs2/compr_rubin.c b/fs/jffs2/compr_rubin.c
index 92e0644b..556de10 100644
--- a/fs/jffs2/compr_rubin.c
+++ b/fs/jffs2/compr_rubin.c
@@ -84,11 +84,6 @@ static inline int pullbit(struct pushpull *pp)
return bit;
}
-static inline int pulledbits(struct pushpull *pp)
-{
- return pp->ofs;
-}
-
static void init_rubin(struct rubin_state *rs, int div, int *bits)
{
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] jffs2: compr_rubin: Remove unused function
2015-01-11 16:36 [PATCH] jffs2: compr_rubin: Remove unused function Rickard Strandqvist
@ 2015-01-12 15:56 ` Richard Weinberger
2015-01-13 4:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2015-01-12 15:56 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: linux-mtd@lists.infradead.org, David Woodhouse, LKML
On Sun, Jan 11, 2015 at 5:36 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Remove the function pulledbits() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Looks good to me.
Reviewed-by: Richard Weinberger <richard@nod.at>
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] jffs2: compr_rubin: Remove unused function
2015-01-11 16:36 [PATCH] jffs2: compr_rubin: Remove unused function Rickard Strandqvist
2015-01-12 15:56 ` Richard Weinberger
@ 2015-01-13 4:40 ` Brian Norris
1 sibling, 0 replies; 3+ messages in thread
From: Brian Norris @ 2015-01-13 4:40 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: linux-mtd, David Woodhouse, linux-kernel
On Sun, Jan 11, 2015 at 05:36:48PM +0100, Rickard Strandqvist wrote:
> Remove the function pulledbits() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Pushed to l2-mtd.git. Thanks.
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-13 4:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-11 16:36 [PATCH] jffs2: compr_rubin: Remove unused function Rickard Strandqvist
2015-01-12 15:56 ` Richard Weinberger
2015-01-13 4:40 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox