From: Brian Norris <computersforpeace@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] MTD: Deletion of checks before the function call "iounmap"
Date: Mon, 19 Jan 2015 09:58:35 -0800 [thread overview]
Message-ID: <20150119175835.GH9759@ld-irv-0074> (raw)
In-Reply-To: <54BBE87C.9020705@users.sourceforge.net>
On Sun, Jan 18, 2015 at 06:08:12PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 18 Jan 2015 17:30:23 +0100
>
> The iounmap() function performs also input parameter validation.
> Thus the test around the call is not needed.
Is this guaranteed for all arch'es? I expect that it would be, but I see
that, for instance, ARM allows replaceable iounmap() for
subarchitectures. Also, I see checks for various sorts of static
mappings in ARM and x86; these likely (always?) cover the NULL case, but
they're not always straightforward.
Anyway, I'm essentially saying that I'd like to be 100% sure we have a
guarantee before dropping all these.
> This issue was detected by using the Coccinelle software.
What script? Hand-rolled I guess?
Brian
next prev parent reply other threads:[~2015-01-19 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-20 12:55 ` [PATCH 1/1] MTD: Deletion of unnecessary checks before two function calls SF Markus Elfring
2014-11-26 6:50 ` Brian Norris
2015-01-18 17:08 ` [PATCH] MTD: Deletion of checks before the function call "iounmap" SF Markus Elfring
2015-01-19 17:58 ` Brian Norris [this message]
2015-01-19 18:19 ` SF Markus Elfring
2015-01-19 18:30 ` Brian Norris
2015-01-19 19:07 ` SF Markus Elfring
2015-01-19 20:31 ` Brian Norris
2015-01-19 22:00 ` SF Markus Elfring
2015-01-22 9:03 ` Brian Norris
2015-01-22 16:28 ` SF Markus Elfring
2015-01-19 18:20 ` Dan Carpenter
2015-01-19 18:32 ` Brian Norris
2015-11-04 19:10 ` [PATCH] UBIFS: Delete unnecessary checks before the function call "iput" SF Markus Elfring
2015-11-06 22:15 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119175835.GH9759@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox