* [patch] mtd: hisilicon: && vs & typo
@ 2015-02-11 10:25 Dan Carpenter
2015-02-12 21:37 ` Brian Norris
2015-02-15 9:07 ` Brian Norris
0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2015-02-11 10:25 UTC (permalink / raw)
To: David Woodhouse; +Cc: kernel-janitors, Zhou Wang, Brian Norris, linux-mtd
The intent was to mask away some bits here, not to test true or false.
Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
index 484e1db..289ad3a 100644
--- a/drivers/mtd/nand/hisi504_nand.c
+++ b/drivers/mtd/nand/hisi504_nand.c
@@ -495,7 +495,7 @@ static void hisi_nfc_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
flag = hinfc_read(host, HINFC504_CON);
if (chip->ecc.mode == NAND_ECC_HW)
hinfc_write(host,
- flag && ~(HINFC504_CON_ECCTYPE_MASK <<
+ flag & ~(HINFC504_CON_ECCTYPE_MASK <<
HINFC504_CON_ECCTYPE_SHIFT), HINFC504_CON);
host->offset = 0;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch] mtd: hisilicon: && vs & typo
2015-02-11 10:25 [patch] mtd: hisilicon: && vs & typo Dan Carpenter
@ 2015-02-12 21:37 ` Brian Norris
2015-02-28 4:44 ` Zhou Wang
2015-02-15 9:07 ` Brian Norris
1 sibling, 1 reply; 5+ messages in thread
From: Brian Norris @ 2015-02-12 21:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, linux-mtd, Zhou Wang, David Woodhouse
Hi,
On Wed, Feb 11, 2015 at 01:25:09PM +0300, Dan Carpenter wrote:
> The intent was to mask away some bits here, not to test true or false.
>
> Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
> index 484e1db..289ad3a 100644
> --- a/drivers/mtd/nand/hisi504_nand.c
> +++ b/drivers/mtd/nand/hisi504_nand.c
> @@ -495,7 +495,7 @@ static void hisi_nfc_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
> flag = hinfc_read(host, HINFC504_CON);
> if (chip->ecc.mode == NAND_ECC_HW)
> hinfc_write(host,
> - flag && ~(HINFC504_CON_ECCTYPE_MASK <<
> + flag & ~(HINFC504_CON_ECCTYPE_MASK <<
Looks good to me. Zhou, can I get an ack?
> HINFC504_CON_ECCTYPE_SHIFT), HINFC504_CON);
>
> host->offset = 0;
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] mtd: hisilicon: && vs & typo
2015-02-12 21:37 ` Brian Norris
@ 2015-02-28 4:44 ` Zhou Wang
0 siblings, 0 replies; 5+ messages in thread
From: Zhou Wang @ 2015-02-28 4:44 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, kernel-janitors, David Woodhouse, Dan Carpenter
On 2015/2/13 5:37, Brian Norris wrote:
> Hi,
>
> On Wed, Feb 11, 2015 at 01:25:09PM +0300, Dan Carpenter wrote:
>> The intent was to mask away some bits here, not to test true or false.
>>
>> Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c
>> index 484e1db..289ad3a 100644
>> --- a/drivers/mtd/nand/hisi504_nand.c
>> +++ b/drivers/mtd/nand/hisi504_nand.c
>> @@ -495,7 +495,7 @@ static void hisi_nfc_cmdfunc(struct mtd_info *mtd, unsigned command, int column,
>> flag = hinfc_read(host, HINFC504_CON);
>> if (chip->ecc.mode == NAND_ECC_HW)
>> hinfc_write(host,
>> - flag && ~(HINFC504_CON_ECCTYPE_MASK <<
>> + flag & ~(HINFC504_CON_ECCTYPE_MASK <<
>
> Looks good to me. Zhou, can I get an ack?
Hi Brian,
Sorry for late for the reason of Chinese new year vacation.
You can apply that above, My mistake there.
Thanks,
Zhou Wang
>
>> HINFC504_CON_ECCTYPE_SHIFT), HINFC504_CON);
>>
>> host->offset = 0;
>
> Brian
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] mtd: hisilicon: && vs & typo
2015-02-11 10:25 [patch] mtd: hisilicon: && vs & typo Dan Carpenter
2015-02-12 21:37 ` Brian Norris
@ 2015-02-15 9:07 ` Brian Norris
2015-02-28 4:47 ` Zhou Wang
1 sibling, 1 reply; 5+ messages in thread
From: Brian Norris @ 2015-02-15 9:07 UTC (permalink / raw)
To: Dan Carpenter; +Cc: kernel-janitors, linux-mtd, Zhou Wang, David Woodhouse
On Wed, Feb 11, 2015 at 01:25:09PM +0300, Dan Carpenter wrote:
> The intent was to mask away some bits here, not to test true or false.
>
> Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Pushed to l2-mtd.git. Thanks.
Brian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch] mtd: hisilicon: && vs & typo
2015-02-15 9:07 ` Brian Norris
@ 2015-02-28 4:47 ` Zhou Wang
0 siblings, 0 replies; 5+ messages in thread
From: Zhou Wang @ 2015-02-28 4:47 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, kernel-janitors, David Woodhouse, Dan Carpenter
On 2015/2/15 17:07, Brian Norris wrote:
> On Wed, Feb 11, 2015 at 01:25:09PM +0300, Dan Carpenter wrote:
>> The intent was to mask away some bits here, not to test true or false.
>>
>> Fix: 54f531f6e332 ('mtd: hisilicon: add a new NAND controller driver for hisilicon hip04 Soc')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Pushed to l2-mtd.git. Thanks.
Hi Brian,
Thanks for the pushing.
Zhou Wang
>
> Brian
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-28 4:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-11 10:25 [patch] mtd: hisilicon: && vs & typo Dan Carpenter
2015-02-12 21:37 ` Brian Norris
2015-02-28 4:44 ` Zhou Wang
2015-02-15 9:07 ` Brian Norris
2015-02-28 4:47 ` Zhou Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox