Re: [PATCH 1/2 v1] mtd: spi-nor: fsl-quadspi: Enable LS1021 support

[Brian Norris <computersforpeace@gmail.com>]

On Fri, Apr 24, 2015 at 06:26:54PM +0800, Haikun Wang wrote:
> Add LS1021 QSPI chip special information
> 
> Signed-off-by: Haikun Wang <haikun.wang@freescale.com>
> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 5d5d362..1742de9 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -194,6 +194,7 @@
>  enum fsl_qspi_devtype {
>  	FSL_QUADSPI_VYBRID,
>  	FSL_QUADSPI_IMX6SX,
> +	FSL_QUADSPI_LS1,
>  };
>  
>  struct fsl_qspi_devtype_data {
> @@ -217,6 +218,12 @@ static struct fsl_qspi_devtype_data imx6sx_data = {
>  	.ahb_buf_size = 1024
>  };
>  
> +static struct fsl_qspi_devtype_data ls1_data = {
> +	.devtype = FSL_QUADSPI_LS1,
> +	.rxfifo = 128,
> +	.txfifo = 64;

Do you compile test your changes? This definition does not use valid C
syntax. This shows that not only did you not test your code, you didn't
even compile it. I can't take your code when you make your lack of
diligence that obvious.

Same thing for your second patch.

Brian

> +};
> +
>  #define FSL_QSPI_MAX_CHIP	4
>  struct fsl_qspi {
>  	struct mtd_info mtd[FSL_QSPI_MAX_CHIP];
> @@ -665,6 +672,7 @@ static int fsl_qspi_nor_setup_last(struct fsl_qspi *q)
>  static struct of_device_id fsl_qspi_dt_ids[] = {
>  	{ .compatible = "fsl,vf610-qspi", .data = (void *)&vybrid_data, },
>  	{ .compatible = "fsl,imx6sx-qspi", .data = (void *)&imx6sx_data, },
> +	{ .compatible = "fsl,ls1-qspi", .data = (void *)&ls1_data, },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, fsl_qspi_dt_ids);