From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/4] mtd: nand: nand_get_flash_type: Print detected ECC strength and size
Date: Thu, 30 Jul 2015 09:23:33 +0200 [thread overview]
Message-ID: <20150730092333.59705873@bbrezillon> (raw)
In-Reply-To: <1438192434-18363-3-git-send-email-hdegoede@redhat.com>
Hi Hans,
On Wed, 29 Jul 2015 19:53:53 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> Print the detected ECC strength and size from nand_get_flash_type().
Indeed, that's an interesting information.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/mtd/nand/nand_base.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index f3fefbf..e2e2690 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -4433,9 +4433,10 @@ ident_done:
> pr_info("%s %s\n", nand_manuf_ids[maf_idx].name,
> type->name);
>
> - pr_info("%d MiB, %s, erase size: %d KiB, page size: %d, OOB size: %d\n",
> + pr_info("%d MiB, %s, erase size: %d KiB, page size: %d, OOB size: %d, ECC strength %d size %d\n",
How about the follwing formalism ?
pr_info("%d MiB, type: %s, erase size: %d KiB, page size: %d, OOB size: %d, ECC: %dbits/%dbytes\n",
or just
pr_info("%d MiB, type: %s, erase size: %d KiB, page size: %d, OOB size: %d, ECC: %d/%d\n",
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-30 7:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 17:53 [PATCH 1/4] mtd: nand: Fix NAND_* options to use unique values Hans de Goede
2015-07-29 17:53 ` [PATCH 2/4] mtd: nand: nand_decode_ext_id(): Fill in ecc strength and size for Samsung Hans de Goede
2015-07-30 7:29 ` Boris Brezillon
2015-07-30 12:19 ` [linux-sunxi] " Hans de Goede
2015-07-29 17:53 ` [PATCH 3/4] mtd: nand: nand_get_flash_type: Print detected ECC strength and size Hans de Goede
2015-07-30 7:23 ` Boris Brezillon [this message]
2015-07-30 12:16 ` [linux-sunxi] " Hans de Goede
2015-07-29 17:53 ` [PATCH 4/4] mtd: nand: print full chip ID Hans de Goede
2015-07-29 23:37 ` [linux-sunxi] " Julian Calaby
2015-07-30 4:19 ` Michal Suchanek
2015-07-30 7:17 ` Boris Brezillon
2015-07-30 10:37 ` Michal Suchanek
2015-07-30 11:52 ` [PATCH v2] " Michal Suchanek
2015-07-30 12:15 ` Hans de Goede
2015-07-29 18:13 ` [PATCH 1/4] mtd: nand: Fix NAND_* options to use unique values Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730092333.59705873@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox