From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Hans de Goede <hdegoede@redhat.com>,
Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/4] mtd: nand: nand_decode_ext_id(): Fill in ecc strength and size for Samsung
Date: Thu, 30 Jul 2015 09:29:14 +0200 [thread overview]
Message-ID: <20150730092914.3616eb5c@bbrezillon> (raw)
In-Reply-To: <1438192434-18363-2-git-send-email-hdegoede@redhat.com>
Hi,
On Wed, 29 Jul 2015 19:53:52 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> On some nand controllers with hw-ecc the controller code wants to know the
> ecc strength and size and having these as 0, 0 is not accepted.
>
> Specifying these in devicetree is possible but undesirable as the nand
> may be different in different production runs of the same board, so it
> is better to get this info from the nand id where possible.
>
> This commit adds code to read the ecc strength and size from the nand for
> Samsung extended-id nands. This code is based on the info for the 5th
> id byte in the datasheets for the following Samsung nands: K9GAG08U0E,
> K9GAG08U0F, K9GAG08X0D, K9GBG08U0A, K9GBG08U0B. These all use these bits
> in the exact same way.
Okay, that's the one I'm not sure about. If that's really the case,
and Samsung is actually using the same layout for all its chips, we
should be good, but as I already stated in the other thread, this was
not the case for Hynix chips.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-30 7:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 17:53 [PATCH 1/4] mtd: nand: Fix NAND_* options to use unique values Hans de Goede
2015-07-29 17:53 ` [PATCH 2/4] mtd: nand: nand_decode_ext_id(): Fill in ecc strength and size for Samsung Hans de Goede
2015-07-30 7:29 ` Boris Brezillon [this message]
2015-07-30 12:19 ` [linux-sunxi] " Hans de Goede
2015-07-29 17:53 ` [PATCH 3/4] mtd: nand: nand_get_flash_type: Print detected ECC strength and size Hans de Goede
2015-07-30 7:23 ` Boris Brezillon
2015-07-30 12:16 ` [linux-sunxi] " Hans de Goede
2015-07-29 17:53 ` [PATCH 4/4] mtd: nand: print full chip ID Hans de Goede
2015-07-29 23:37 ` [linux-sunxi] " Julian Calaby
2015-07-30 4:19 ` Michal Suchanek
2015-07-30 7:17 ` Boris Brezillon
2015-07-30 10:37 ` Michal Suchanek
2015-07-30 11:52 ` [PATCH v2] " Michal Suchanek
2015-07-30 12:15 ` Hans de Goede
2015-07-29 18:13 ` [PATCH 1/4] mtd: nand: Fix NAND_* options to use unique values Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730092914.3616eb5c@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox