From: Dave Chinner <david@fromorbit.com>
To: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
Cc: eguan@redhat.com, fstests@vger.kernel.org, dedekind1@gmail.com,
richard.weinberger@gmail.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/5] xfstest: generic/219 add _require_odirect
Date: Mon, 3 Aug 2015 13:59:09 +1000 [thread overview]
Message-ID: <20150803035909.GP3902@dastard> (raw)
In-Reply-To: <1438236417-24612-3-git-send-email-yangds.fnst@cn.fujitsu.com>
On Thu, Jul 30, 2015 at 02:06:54PM +0800, Dongsheng Yang wrote:
> generic/219 is testing quota in three use cases including
> Direct I/O. So we have to add a dependence to odirect in
> this test.
Hmmm - you've modified on only 2 tests here in this patch series
that use direct IO. There are many more - just looking for direct IO
comments, these generic tests use direct IO in some way, and there
are others that such usage is not obvious (e.g. this patch to
generic/219):
generic/091
generic/113
generic/130
generic/214
generic/224
generic/263
shared/272
And all the aio/dio tests:
generic/036
generic/198
generic/207
generic/208
generic/209
generic/210
generic/211
generic/212
generic/239
generic/240
generic/323
And there are others that run fio that uses DIO, too, like
generic/299
generic/300
And so on. I haven't even looked at all the fsx tests that might
use DIO, and I know that some of them are not listed above...
On the whole, I think ubifs would be better to implement DIO via
buffered fallback that to make us have to annotate every test that
uses DIO in some way...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-08-03 3:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 6:06 [PATCH 0/5] xfstests: introduce ubifs in xfstests Dongsheng Yang
2015-07-30 6:06 ` [PATCH 1/5] xfstest: add ubifs support Dongsheng Yang
2015-08-03 4:12 ` Dave Chinner
2015-08-03 4:44 ` Dongsheng Yang
2015-08-03 4:47 ` Dongsheng Yang
2015-08-03 5:51 ` Dave Chinner
2015-07-30 6:06 ` [PATCH 2/5] xfstest: generic/219 add _require_odirect Dongsheng Yang
2015-08-03 3:11 ` Eryu Guan
2015-08-03 3:59 ` Dave Chinner [this message]
2015-08-03 5:01 ` Dongsheng Yang
2015-08-03 5:55 ` Dave Chinner
2015-07-30 6:06 ` [PATCH 3/5] xfstest: generic/125 " Dongsheng Yang
2015-08-03 3:12 ` Eryu Guan
2015-07-30 6:06 ` [PATCH 4/5] xfstest: introduce subtestset for ubifs Dongsheng Yang
2015-08-03 3:28 ` Eryu Guan
2015-08-03 5:12 ` Dongsheng Yang
2015-07-30 6:06 ` [PATCH 5/5] xfstest: add quota tests to ubifs Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150803035909.GP3902@dastard \
--to=david@fromorbit.com \
--cc=dedekind1@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=yangds.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox