* [PATCH 1/9] mtd: nand: omap2: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
@ 2016-04-13 12:06 ` Rafał Miłecki
2016-04-13 12:06 ` [PATCH 2/9] mtd: nand: s3c2410: " Rafał Miłecki
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:06 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/omap2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 8921283..9c3e732 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1816,6 +1816,7 @@ static int omap_nand_probe(struct platform_device *pdev)
*/
if (info->ecc_opt == OMAP_ECC_HAM1_CODE_SW) {
nand_chip->ecc.mode = NAND_ECC_SOFT;
+ nand_chip->ecc.algo = NAND_ECC_HAMMING;
goto scan_tail;
}
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/9] mtd: nand: s3c2410: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
2016-04-13 12:06 ` [PATCH 1/9] mtd: nand: omap2: set ECC algorithm explicitly Rafał Miłecki
@ 2016-04-13 12:06 ` Rafał Miłecki
2016-04-13 12:06 ` [PATCH 3/9] mtd: nand: sh_flctl: " Rafał Miłecki
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:06 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Kukjin Kim,
Krzysztof Kozlowski, Richard Weinberger, David Woodhouse,
Brian Norris, moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES,
moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/s3c2410.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index 86ffb73..6e72679 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -860,6 +860,7 @@ static void s3c2410_nand_init_chip(struct s3c2410_nand_info *info,
}
#else
chip->ecc.mode = NAND_ECC_SOFT;
+ chip->ecc.algo = NAND_ECC_HAMMING;
#endif
if (set->disable_ecc)
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/9] mtd: nand: sh_flctl: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
2016-04-13 12:06 ` [PATCH 1/9] mtd: nand: omap2: set ECC algorithm explicitly Rafał Miłecki
2016-04-13 12:06 ` [PATCH 2/9] mtd: nand: s3c2410: " Rafał Miłecki
@ 2016-04-13 12:06 ` Rafał Miłecki
2016-04-13 12:06 ` [PATCH 4/9] mtd: nand: au1550nd: " Rafał Miłecki
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:06 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/sh_flctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index 4814402..5c4143b 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -1005,6 +1005,7 @@ static int flctl_chip_init_tail(struct mtd_info *mtd)
flctl->flcmncr_base |= _4ECCEN;
} else {
chip->ecc.mode = NAND_ECC_SOFT;
+ chip->ecc.algo = NAND_ECC_HAMMING;
}
return 0;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/9] mtd: nand: au1550nd: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (2 preceding siblings ...)
2016-04-13 12:06 ` [PATCH 3/9] mtd: nand: sh_flctl: " Rafał Miłecki
@ 2016-04-13 12:06 ` Rafał Miłecki
2016-04-13 12:06 ` [PATCH 5/9] mtd: nand: mpc5121_nfc: " Rafał Miłecki
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:06 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/au1550nd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/au1550nd.c b/drivers/mtd/nand/au1550nd.c
index 341ea49..9bf6d99 100644
--- a/drivers/mtd/nand/au1550nd.c
+++ b/drivers/mtd/nand/au1550nd.c
@@ -459,6 +459,7 @@ static int au1550nd_probe(struct platform_device *pdev)
/* 30 us command delay time */
this->chip_delay = 30;
this->ecc.mode = NAND_ECC_SOFT;
+ this->ecc.algo = NAND_ECC_HAMMING;
if (pd->devwidth)
this->options |= NAND_BUSWIDTH_16;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/9] mtd: nand: mpc5121_nfc: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (3 preceding siblings ...)
2016-04-13 12:06 ` [PATCH 4/9] mtd: nand: au1550nd: " Rafał Miłecki
@ 2016-04-13 12:06 ` Rafał Miłecki
2016-04-13 12:06 ` [PATCH 6/9] mtd: nand: cmx270: " Rafał Miłecki
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:06 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/mpc5121_nfc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/mpc5121_nfc.c b/drivers/mtd/nand/mpc5121_nfc.c
index 5d7843f..7eacb2f 100644
--- a/drivers/mtd/nand/mpc5121_nfc.c
+++ b/drivers/mtd/nand/mpc5121_nfc.c
@@ -710,6 +710,7 @@ static int mpc5121_nfc_probe(struct platform_device *op)
chip->select_chip = mpc5121_nfc_select_chip;
chip->bbt_options = NAND_BBT_USE_FLASH;
chip->ecc.mode = NAND_ECC_SOFT;
+ chip->ecc.algo = NAND_ECC_HAMMING;
/* Support external chip-select logic on ADS5121 board */
if (of_machine_is_compatible("fsl,mpc5121ads")) {
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 6/9] mtd: nand: cmx270: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (4 preceding siblings ...)
2016-04-13 12:06 ` [PATCH 5/9] mtd: nand: mpc5121_nfc: " Rafał Miłecki
@ 2016-04-13 12:06 ` Rafał Miłecki
2016-04-13 12:07 ` [PATCH 7/9] mtd: nand: fsl_upm: " Rafał Miłecki
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:06 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/cmx270_nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/cmx270_nand.c b/drivers/mtd/nand/cmx270_nand.c
index 6f97ebb..4913378 100644
--- a/drivers/mtd/nand/cmx270_nand.c
+++ b/drivers/mtd/nand/cmx270_nand.c
@@ -187,6 +187,7 @@ static int __init cmx270_init(void)
/* 15 us command delay time */
this->chip_delay = 20;
this->ecc.mode = NAND_ECC_SOFT;
+ this->ecc.algo = NAND_ECC_HAMMING;
/* read/write functions */
this->read_byte = cmx270_read_byte;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 7/9] mtd: nand: fsl_upm: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (5 preceding siblings ...)
2016-04-13 12:06 ` [PATCH 6/9] mtd: nand: cmx270: " Rafał Miłecki
@ 2016-04-13 12:07 ` Rafał Miłecki
2016-04-13 12:07 ` [PATCH 8/9] mtd: nand: fsl_ifc: " Rafał Miłecki
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:07 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/fsl_upm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/fsl_upm.c b/drivers/mtd/nand/fsl_upm.c
index cafd12d..d85fa25 100644
--- a/drivers/mtd/nand/fsl_upm.c
+++ b/drivers/mtd/nand/fsl_upm.c
@@ -170,6 +170,7 @@ static int fun_chip_init(struct fsl_upm_nand *fun,
fun->chip.read_buf = fun_read_buf;
fun->chip.write_buf = fun_write_buf;
fun->chip.ecc.mode = NAND_ECC_SOFT;
+ fun->chip.ecc.algo = NAND_ECC_HAMMING;
if (fun->mchip_count > 1)
fun->chip.select_chip = fun_select_chip;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 8/9] mtd: nand: fsl_ifc: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (6 preceding siblings ...)
2016-04-13 12:07 ` [PATCH 7/9] mtd: nand: fsl_upm: " Rafał Miłecki
@ 2016-04-13 12:07 ` Rafał Miłecki
2016-04-13 12:07 ` [PATCH 9/9] mtd: nand: fsl_elbc: " Rafał Miłecki
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:07 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/fsl_ifc_nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index f8a016f..a0b277c 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -989,6 +989,7 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
chip->ecc.layout = layout;
} else {
chip->ecc.mode = NAND_ECC_SOFT;
+ chip->ecc.algo = NAND_ECC_HAMMING;
}
if (ctrl->version == FSL_IFC_VERSION_1_1_0)
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 9/9] mtd: nand: fsl_elbc: set ECC algorithm explicitly
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (7 preceding siblings ...)
2016-04-13 12:07 ` [PATCH 8/9] mtd: nand: fsl_ifc: " Rafał Miłecki
@ 2016-04-13 12:07 ` Rafał Miłecki
2016-04-13 17:25 ` [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Boris Brezillon
2016-04-14 10:01 ` Boris Brezillon
10 siblings, 0 replies; 12+ messages in thread
From: Rafał Miłecki @ 2016-04-13 12:07 UTC (permalink / raw)
To: Boris Brezillon
Cc: linux-mtd, Rafał Miłecki, Richard Weinberger,
David Woodhouse, Brian Norris, open list
This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to
enum nand_ecc_algo).
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/mtd/nand/fsl_elbc_nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/nand/fsl_elbc_nand.c b/drivers/mtd/nand/fsl_elbc_nand.c
index 059d5f7..9d2d191 100644
--- a/drivers/mtd/nand/fsl_elbc_nand.c
+++ b/drivers/mtd/nand/fsl_elbc_nand.c
@@ -789,6 +789,7 @@ static int fsl_elbc_chip_init(struct fsl_elbc_mtd *priv)
} else {
/* otherwise fall back to default software ECC */
chip->ecc.mode = NAND_ECC_SOFT;
+ chip->ecc.algo = NAND_ECC_HAMMING;
}
return 0;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2)
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (8 preceding siblings ...)
2016-04-13 12:07 ` [PATCH 9/9] mtd: nand: fsl_elbc: " Rafał Miłecki
@ 2016-04-13 17:25 ` Boris Brezillon
2016-04-14 10:01 ` Boris Brezillon
10 siblings, 0 replies; 12+ messages in thread
From: Boris Brezillon @ 2016-04-13 17:25 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-mtd
Hi Rafal,
On Wed, 13 Apr 2016 14:06:53 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> This follow process of using enum nand_ecc_algo in order to clean
> nand_ecc_modes_t.
>
> All patches were compile-tested.
>
> This work is based on the nand/next branch.
I'll apply part 2 soon, but can you please provide a single patchset
containing all the changes instead of splitting it in several series?
Thanks,
Boris
>
> Rafał Miłecki (9):
> mtd: nand: omap2: set ECC algorithm explicitly
> mtd: nand: s3c2410: set ECC algorithm explicitly
> mtd: nand: sh_flctl: set ECC algorithm explicitly
> mtd: nand: au1550nd: set ECC algorithm explicitly
> mtd: nand: mpc5121_nfc: set ECC algorithm explicitly
> mtd: nand: cmx270: set ECC algorithm explicitly
> mtd: nand: fsl_upm: set ECC algorithm explicitly
> mtd: nand: fsl_ifc: set ECC algorithm explicitly
> mtd: nand: fsl_elbc: set ECC algorithm explicitly
>
> drivers/mtd/nand/au1550nd.c | 1 +
> drivers/mtd/nand/cmx270_nand.c | 1 +
> drivers/mtd/nand/fsl_elbc_nand.c | 1 +
> drivers/mtd/nand/fsl_ifc_nand.c | 1 +
> drivers/mtd/nand/fsl_upm.c | 1 +
> drivers/mtd/nand/mpc5121_nfc.c | 1 +
> drivers/mtd/nand/omap2.c | 1 +
> drivers/mtd/nand/s3c2410.c | 1 +
> drivers/mtd/nand/sh_flctl.c | 1 +
> 9 files changed, 9 insertions(+)
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2)
2016-04-13 12:06 [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Rafał Miłecki
` (9 preceding siblings ...)
2016-04-13 17:25 ` [PATCH 0/9] mtd: nand: set ECC algorithm explicitly (part 2) Boris Brezillon
@ 2016-04-14 10:01 ` Boris Brezillon
10 siblings, 0 replies; 12+ messages in thread
From: Boris Brezillon @ 2016-04-14 10:01 UTC (permalink / raw)
To: Rafał Miłecki; +Cc: linux-mtd
Hi Rafal,
On Wed, 13 Apr 2016 14:06:53 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> This follow process of using enum nand_ecc_algo in order to clean
> nand_ecc_modes_t.
>
> All patches were compile-tested.
>
> This work is based on the nand/next branch.
Applied (waiting for the last part).
Thanks,
Boris
>
> Rafał Miłecki (9):
> mtd: nand: omap2: set ECC algorithm explicitly
> mtd: nand: s3c2410: set ECC algorithm explicitly
> mtd: nand: sh_flctl: set ECC algorithm explicitly
> mtd: nand: au1550nd: set ECC algorithm explicitly
> mtd: nand: mpc5121_nfc: set ECC algorithm explicitly
> mtd: nand: cmx270: set ECC algorithm explicitly
> mtd: nand: fsl_upm: set ECC algorithm explicitly
> mtd: nand: fsl_ifc: set ECC algorithm explicitly
> mtd: nand: fsl_elbc: set ECC algorithm explicitly
>
> drivers/mtd/nand/au1550nd.c | 1 +
> drivers/mtd/nand/cmx270_nand.c | 1 +
> drivers/mtd/nand/fsl_elbc_nand.c | 1 +
> drivers/mtd/nand/fsl_ifc_nand.c | 1 +
> drivers/mtd/nand/fsl_upm.c | 1 +
> drivers/mtd/nand/mpc5121_nfc.c | 1 +
> drivers/mtd/nand/omap2.c | 1 +
> drivers/mtd/nand/s3c2410.c | 1 +
> drivers/mtd/nand/sh_flctl.c | 1 +
> 9 files changed, 9 insertions(+)
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 12+ messages in thread