* [PATCH] mtd: nand: atmel: mark resume function __maybe_unused
@ 2017-05-31 8:19 Arnd Bergmann
2017-05-31 14:32 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-05-31 8:19 UTC (permalink / raw)
To: Boris Brezillon
Cc: Arnd Bergmann, Wenyou Yang, Josh Wu, Richard Weinberger,
David Woodhouse, Brian Norris, Marek Vasut, Cyrille Pitchen,
Nicolas Ferre, linux-mtd, linux-kernel
The newly added suspend/resume support causes a harmless warning:
drivers/mtd/nand/atmel/nand-controller.c:2513:12: error: 'atmel_nand_controller_resume' defined but not used [-Werror=unused-function]
This shuts up the warning with a __maybe_unused annotation.
Fixes: b107007a7114 ("mtd: nand: atmel: Add PM ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mtd/nand/atmel/nand-controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
index 6055831c953f..d24e67b95167 100644
--- a/drivers/mtd/nand/atmel/nand-controller.c
+++ b/drivers/mtd/nand/atmel/nand-controller.c
@@ -2510,7 +2510,7 @@ static int atmel_nand_controller_remove(struct platform_device *pdev)
return nc->caps->ops->remove(nc);
}
-static int atmel_nand_controller_resume(struct device *dev)
+static __maybe_unused int atmel_nand_controller_resume(struct device *dev)
{
struct atmel_nand_controller *nc = dev_get_drvdata(dev);
struct atmel_nand *nand;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mtd: nand: atmel: mark resume function __maybe_unused
2017-05-31 8:19 [PATCH] mtd: nand: atmel: mark resume function __maybe_unused Arnd Bergmann
@ 2017-05-31 14:32 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2017-05-31 14:32 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Wenyou Yang, Josh Wu, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen, Nicolas Ferre,
linux-mtd, linux-kernel
On Wed, 31 May 2017 10:19:26 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added suspend/resume support causes a harmless warning:
>
> drivers/mtd/nand/atmel/nand-controller.c:2513:12: error: 'atmel_nand_controller_resume' defined but not used [-Werror=unused-function]
>
> This shuts up the warning with a __maybe_unused annotation.
Applied to nand/next.
Thanks,
Boris
>
> Fixes: b107007a7114 ("mtd: nand: atmel: Add PM ops")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mtd/nand/atmel/nand-controller.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index 6055831c953f..d24e67b95167 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -2510,7 +2510,7 @@ static int atmel_nand_controller_remove(struct platform_device *pdev)
> return nc->caps->ops->remove(nc);
> }
>
> -static int atmel_nand_controller_resume(struct device *dev)
> +static __maybe_unused int atmel_nand_controller_resume(struct device *dev)
> {
> struct atmel_nand_controller *nc = dev_get_drvdata(dev);
> struct atmel_nand *nand;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-31 14:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 8:19 [PATCH] mtd: nand: atmel: mark resume function __maybe_unused Arnd Bergmann
2017-05-31 14:32 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox