* [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2
@ 2017-06-01 9:01 xiaolei.li
2017-06-01 19:23 ` Richard Weinberger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: xiaolei.li @ 2017-06-01 9:01 UTC (permalink / raw)
To: boris.brezillon, computersforpeace
Cc: dwmw2, linux-mtd, linux-mediatek, xiaolei.li
From: Xiaolei Li <xiaolei.li@mediatek.com>
Write size in function write_eraseblock2 is subpgsize * k.
It is wrong to check whether written is equal to subpgsize after each
mtd_write.
Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
---
drivers/mtd/tests/subpagetest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c
index aecc6ce..fa2519a 100644
--- a/drivers/mtd/tests/subpagetest.c
+++ b/drivers/mtd/tests/subpagetest.c
@@ -102,7 +102,7 @@ static int write_eraseblock2(int ebnum)
if (unlikely(err || written != subpgsize * k)) {
pr_err("error: write failed at %#llx\n",
(long long)addr);
- if (written != subpgsize) {
+ if (written != subpgsize * k) {
pr_err(" write size: %#x\n",
subpgsize * k);
pr_err(" written: %#08zx\n",
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2
2017-06-01 9:01 [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2 xiaolei.li
@ 2017-06-01 19:23 ` Richard Weinberger
2017-06-02 7:14 ` Boris Brezillon
2017-06-08 23:43 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2017-06-01 19:23 UTC (permalink / raw)
To: xiaolei.li
Cc: Boris Brezillon, Brian Norris, linux-mtd@lists.infradead.org,
linux-mediatek, David Woodhouse, David Oberhollenzer
On Thu, Jun 1, 2017 at 11:01 AM, <xiaolei.li@mediatek.com> wrote:
> From: Xiaolei Li <xiaolei.li@mediatek.com>
>
> Write size in function write_eraseblock2 is subpgsize * k.
> It is wrong to check whether written is equal to subpgsize after each
> mtd_write.
>
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
> ---
> drivers/mtd/tests/subpagetest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c
> index aecc6ce..fa2519a 100644
> --- a/drivers/mtd/tests/subpagetest.c
> +++ b/drivers/mtd/tests/subpagetest.c
> @@ -102,7 +102,7 @@ static int write_eraseblock2(int ebnum)
> if (unlikely(err || written != subpgsize * k)) {
> pr_err("error: write failed at %#llx\n",
> (long long)addr);
> - if (written != subpgsize) {
> + if (written != subpgsize * k) {
> pr_err(" write size: %#x\n",
> subpgsize * k);
> pr_err(" written: %#08zx\n",
Reviewed-by: Richard Weinberger <richard@nod.at>
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2
2017-06-01 9:01 [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2 xiaolei.li
2017-06-01 19:23 ` Richard Weinberger
@ 2017-06-02 7:14 ` Boris Brezillon
2017-06-08 23:43 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2017-06-02 7:14 UTC (permalink / raw)
To: xiaolei.li; +Cc: computersforpeace, dwmw2, linux-mtd, linux-mediatek
On Thu, 1 Jun 2017 17:01:19 +0800
<xiaolei.li@mediatek.com> wrote:
> From: Xiaolei Li <xiaolei.li@mediatek.com>
>
> Write size in function write_eraseblock2 is subpgsize * k.
> It is wrong to check whether written is equal to subpgsize after each
> mtd_write.
>
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/tests/subpagetest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/tests/subpagetest.c b/drivers/mtd/tests/subpagetest.c
> index aecc6ce..fa2519a 100644
> --- a/drivers/mtd/tests/subpagetest.c
> +++ b/drivers/mtd/tests/subpagetest.c
> @@ -102,7 +102,7 @@ static int write_eraseblock2(int ebnum)
> if (unlikely(err || written != subpgsize * k)) {
> pr_err("error: write failed at %#llx\n",
> (long long)addr);
> - if (written != subpgsize) {
> + if (written != subpgsize * k) {
> pr_err(" write size: %#x\n",
> subpgsize * k);
> pr_err(" written: %#08zx\n",
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2
2017-06-01 9:01 [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2 xiaolei.li
2017-06-01 19:23 ` Richard Weinberger
2017-06-02 7:14 ` Boris Brezillon
@ 2017-06-08 23:43 ` Brian Norris
2 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2017-06-08 23:43 UTC (permalink / raw)
To: xiaolei.li; +Cc: boris.brezillon, dwmw2, linux-mtd, linux-mediatek
On Thu, Jun 01, 2017 at 05:01:19PM +0800, xiaolei.li@mediatek.com wrote:
> From: Xiaolei Li <xiaolei.li@mediatek.com>
>
> Write size in function write_eraseblock2 is subpgsize * k.
> It is wrong to check whether written is equal to subpgsize after each
> mtd_write.
>
> Signed-off-by: Xiaolei Li <xiaolei.li@mediatek.com>
Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-08 23:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-01 9:01 [PATCH] mtd: subpagetest: fix wrong written check in function write_eraseblock2 xiaolei.li
2017-06-01 19:23 ` Richard Weinberger
2017-06-02 7:14 ` Boris Brezillon
2017-06-08 23:43 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox