* [PATCH] Fix typo in comment. @ 2017-05-30 7:41 Matthias Lange 2017-05-31 9:22 ` Boris Brezillon 0 siblings, 1 reply; 4+ messages in thread From: Matthias Lange @ 2017-05-30 7:41 UTC (permalink / raw) To: linux-mtd, han.xu, computersforpeace, richard, dwmw2; +Cc: Matthias Lange Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com> --- drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c index 141bd70..41f53ae 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode) nand->select_chip(mtd, 0); - /* [1] send SET FEATURE commond to NAND */ + /* [1] send SET FEATURE command to NAND */ feature[0] = mode; ret = nand->onfi_set_features(mtd, nand, ONFI_FEATURE_ADDR_TIMING_MODE, feature); -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in comment. 2017-05-30 7:41 [PATCH] Fix typo in comment Matthias Lange @ 2017-05-31 9:22 ` Boris Brezillon 2017-05-31 15:07 ` Matthias Lange 0 siblings, 1 reply; 4+ messages in thread From: Boris Brezillon @ 2017-05-31 9:22 UTC (permalink / raw) To: Matthias Lange; +Cc: linux-mtd, han.xu, computersforpeace, richard, dwmw2 Hi Mattias, On Tue, 30 May 2017 09:41:31 +0200 Matthias Lange <matthias.lange@kernkonzept.com> wrote: Commit title should be prefixed with "mtd: nand: gpmi: ". > Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com> > --- > drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c > index 141bd70..41f53ae 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c > @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode) > > nand->select_chip(mtd, 0); > > - /* [1] send SET FEATURE commond to NAND */ > + /* [1] send SET FEATURE command to NAND */ > feature[0] = mode; > ret = nand->onfi_set_features(mtd, nand, > ONFI_FEATURE_ADDR_TIMING_MODE, feature); ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in comment. 2017-05-31 9:22 ` Boris Brezillon @ 2017-05-31 15:07 ` Matthias Lange 2017-06-02 7:23 ` Boris Brezillon 0 siblings, 1 reply; 4+ messages in thread From: Matthias Lange @ 2017-05-31 15:07 UTC (permalink / raw) To: Boris Brezillon; +Cc: linux-mtd, han.xu, computersforpeace, richard, dwmw2 [-- Attachment #1: Type: text/plain, Size: 1043 bytes --] Hi Boris, please consider the new version of the commit. Best, Matthias. On 05/31/2017 11:22 AM, Boris Brezillon wrote: > Hi Mattias, > > On Tue, 30 May 2017 09:41:31 +0200 > Matthias Lange <matthias.lange@kernkonzept.com> wrote: > > Commit title should be prefixed with "mtd: nand: gpmi: ". > >> Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com> >> --- >> drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c >> index 141bd70..41f53ae 100644 >> --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c >> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c >> @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode) >> >> nand->select_chip(mtd, 0); >> >> - /* [1] send SET FEATURE commond to NAND */ >> + /* [1] send SET FEATURE command to NAND */ >> feature[0] = mode; >> ret = nand->onfi_set_features(mtd, nand, >> ONFI_FEATURE_ADDR_TIMING_MODE, feature); [-- Attachment #2: 0001-mtd-nand-gpmi-fix-typo-in-comment.patch --] [-- Type: text/x-patch, Size: 919 bytes --] >From 09b2ba7b74617888376e1e8022b1e68d022473a9 Mon Sep 17 00:00:00 2001 From: Matthias Lange <matthias.lange@kernkonzept.com> Date: Tue, 30 May 2017 09:35:03 +0200 Subject: [PATCH] mtd: nand: gpmi: fix typo in comment Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com> --- drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c index 141bd70..41f53ae 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode) nand->select_chip(mtd, 0); - /* [1] send SET FEATURE commond to NAND */ + /* [1] send SET FEATURE command to NAND */ feature[0] = mode; ret = nand->onfi_set_features(mtd, nand, ONFI_FEATURE_ADDR_TIMING_MODE, feature); -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in comment. 2017-05-31 15:07 ` Matthias Lange @ 2017-06-02 7:23 ` Boris Brezillon 0 siblings, 0 replies; 4+ messages in thread From: Boris Brezillon @ 2017-06-02 7:23 UTC (permalink / raw) To: Matthias Lange; +Cc: linux-mtd, han.xu, computersforpeace, richard, dwmw2 On Wed, 31 May 2017 17:07:54 +0200 Matthias Lange <matthias.lange@kernkonzept.com> wrote: > Hi Boris, > > please consider the new version of the commit. Can you send the patch you've put in attachment using git send-email and Cc all relevant maintainers? > > Best, > Matthias. > > > On 05/31/2017 11:22 AM, Boris Brezillon wrote: > > Hi Mattias, > > > > On Tue, 30 May 2017 09:41:31 +0200 > > Matthias Lange <matthias.lange@kernkonzept.com> wrote: > > > > Commit title should be prefixed with "mtd: nand: gpmi: ". > > > >> Signed-off-by: Matthias Lange <matthias.lange@kernkonzept.com> > >> --- > >> drivers/mtd/nand/gpmi-nand/gpmi-lib.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c > >> index 141bd70..41f53ae 100644 > >> --- a/drivers/mtd/nand/gpmi-nand/gpmi-lib.c > >> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-lib.c > >> @@ -932,7 +932,7 @@ static int enable_edo_mode(struct gpmi_nand_data *this, int mode) > >> > >> nand->select_chip(mtd, 0); > >> > >> - /* [1] send SET FEATURE commond to NAND */ > >> + /* [1] send SET FEATURE command to NAND */ > >> feature[0] = mode; > >> ret = nand->onfi_set_features(mtd, nand, > >> ONFI_FEATURE_ADDR_TIMING_MODE, feature); ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-02 7:24 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-05-30 7:41 [PATCH] Fix typo in comment Matthias Lange 2017-05-31 9:22 ` Boris Brezillon 2017-05-31 15:07 ` Matthias Lange 2017-06-02 7:23 ` Boris Brezillon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox