* [PATCH] mtd: nand: orion: Handle return value of clk_prepare_enable
@ 2017-06-01 10:58 Arvind Yadav
2017-06-07 7:32 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-01 10:58 UTC (permalink / raw)
To: boris.brezillon, richard, dwmw2, computersforpeace, marek.vasut,
cyrille.pitchen
Cc: linux-mtd, linux-kernel
clk_prepare_enable() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/mtd/nand/orion_nand.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
index f8e463a..209170e 100644
--- a/drivers/mtd/nand/orion_nand.c
+++ b/drivers/mtd/nand/orion_nand.c
@@ -166,7 +166,11 @@ static int __init orion_nand_probe(struct platform_device *pdev)
}
}
- clk_prepare_enable(info->clk);
+ ret = clk_prepare_enable(info->clk);
+ if (ret) {
+ dev_err(&pdev->dev, "failed to prepare clock!\n");
+ return ret;
+ }
ret = nand_scan(mtd, 1);
if (ret)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mtd: nand: orion: Handle return value of clk_prepare_enable
2017-06-01 10:58 [PATCH] mtd: nand: orion: Handle return value of clk_prepare_enable Arvind Yadav
@ 2017-06-07 7:32 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2017-06-07 7:32 UTC (permalink / raw)
To: Arvind Yadav
Cc: richard, dwmw2, computersforpeace, marek.vasut, cyrille.pitchen,
linux-mtd, linux-kernel
On Thu, 1 Jun 2017 16:28:15 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
Applied.
Thanks,
Boris
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/mtd/nand/orion_nand.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
> index f8e463a..209170e 100644
> --- a/drivers/mtd/nand/orion_nand.c
> +++ b/drivers/mtd/nand/orion_nand.c
> @@ -166,7 +166,11 @@ static int __init orion_nand_probe(struct platform_device *pdev)
> }
> }
>
> - clk_prepare_enable(info->clk);
> + ret = clk_prepare_enable(info->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to prepare clock!\n");
> + return ret;
> + }
>
> ret = nand_scan(mtd, 1);
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-07 7:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-01 10:58 [PATCH] mtd: nand: orion: Handle return value of clk_prepare_enable Arvind Yadav
2017-06-07 7:32 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox