* [PATCH] driver: mtd: ifc: Initialize SRAM for all version >= 1.0
@ 2017-06-09 10:57 Prabhakar Kushwaha
2017-06-20 7:19 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Prabhakar Kushwaha @ 2017-06-09 10:57 UTC (permalink / raw)
To: linux-mtd; +Cc: dedekind1, oss, computersforpeace, Prabhakar Kushwaha
All IFC version >= 1.0 use 28nm technology for SRAM. Here SRAM has
a requirement to initialize before any read operation performed for
avoiding ECC Error.
So update condition check to initialize SRAM for all IFC version >= 1.0.0
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
drivers/mtd/nand/fsl_ifc_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index d1570f5..eca269d 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -904,7 +904,7 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
chip->ecc.algo = NAND_ECC_HAMMING;
}
- if (ctrl->version == FSL_IFC_VERSION_1_1_0)
+ if (ctrl->version >= FSL_IFC_VERSION_1_1_0)
fsl_ifc_sram_init(priv);
return 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] driver: mtd: ifc: Initialize SRAM for all version >= 1.0
2017-06-09 10:57 [PATCH] driver: mtd: ifc: Initialize SRAM for all version >= 1.0 Prabhakar Kushwaha
@ 2017-06-20 7:19 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2017-06-20 7:19 UTC (permalink / raw)
To: Prabhakar Kushwaha; +Cc: linux-mtd, oss, computersforpeace, dedekind1
Hi Prabhakar,
Please Cc me next time you submit a NAND related change.
On Fri, 9 Jun 2017 16:27:21 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> All IFC version >= 1.0 use 28nm technology for SRAM. Here SRAM has
> a requirement to initialize before any read operation performed for
> avoiding ECC Error.
>
> So update condition check to initialize SRAM for all IFC version >= 1.0.0
Applied after changing the subject prefix to "mtd: nand: ifc".
Thanks,
Boris
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> drivers/mtd/nand/fsl_ifc_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index d1570f5..eca269d 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -904,7 +904,7 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
> chip->ecc.algo = NAND_ECC_HAMMING;
> }
>
> - if (ctrl->version == FSL_IFC_VERSION_1_1_0)
> + if (ctrl->version >= FSL_IFC_VERSION_1_1_0)
> fsl_ifc_sram_init(priv);
>
> return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-20 7:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 10:57 [PATCH] driver: mtd: ifc: Initialize SRAM for all version >= 1.0 Prabhakar Kushwaha
2017-06-20 7:19 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox