From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Cc: <linux-mtd@lists.infradead.org>,
oss@buserror.net, computersforpeace@gmail.com,
dedekind1@gmail.com
Subject: Re: [PATCH] driver: mtd: ifc: update bufnum mask for ver >= 2.0.0
Date: Tue, 20 Jun 2017 09:21:35 +0200 [thread overview]
Message-ID: <20170620092135.1a584928@bbrezillon> (raw)
In-Reply-To: <1497005857-7796-1-git-send-email-prabhakar.kushwaha@nxp.com>
Hi,
Subject prefix should be "mtd: nand: ifc".
On Fri, 9 Jun 2017 16:27:37 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> Bufnum mask is used to calculate page position in the internal SRAM.
>
> As IFC version 2.0.0 has 16KB of internal SRAM as compared to older
> versions which had 8KB. Hence bufnum mask needs to be updated.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> drivers/mtd/nand/fsl_ifc_nand.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index eca269d..785e9ee 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -907,6 +907,9 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
> if (ctrl->version >= FSL_IFC_VERSION_1_1_0)
> fsl_ifc_sram_init(priv);
>
Can you add a comment explaining why this is done (just put the content
of the commit message here).
> + if (ctrl->version >= FSL_IFC_VERSION_2_0_0)
> + priv->bufnum_mask = (priv->bufnum_mask * 2) + 1;
> +
> return 0;
> }
>
prev parent reply other threads:[~2017-06-20 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:57 [PATCH] driver: mtd: ifc: update bufnum mask for ver >= 2.0.0 Prabhakar Kushwaha
2017-06-20 7:21 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620092135.1a584928@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=oss@buserror.net \
--cc=prabhakar.kushwaha@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox