* [PATCH] driver: mtd: ifc: update bufnum mask for ver >= 2.0.0
@ 2017-06-09 10:57 Prabhakar Kushwaha
2017-06-20 7:21 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Prabhakar Kushwaha @ 2017-06-09 10:57 UTC (permalink / raw)
To: linux-mtd; +Cc: dedekind1, oss, computersforpeace, Prabhakar Kushwaha
Bufnum mask is used to calculate page position in the internal SRAM.
As IFC version 2.0.0 has 16KB of internal SRAM as compared to older
versions which had 8KB. Hence bufnum mask needs to be updated.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
drivers/mtd/nand/fsl_ifc_nand.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
index eca269d..785e9ee 100644
--- a/drivers/mtd/nand/fsl_ifc_nand.c
+++ b/drivers/mtd/nand/fsl_ifc_nand.c
@@ -907,6 +907,9 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
if (ctrl->version >= FSL_IFC_VERSION_1_1_0)
fsl_ifc_sram_init(priv);
+ if (ctrl->version >= FSL_IFC_VERSION_2_0_0)
+ priv->bufnum_mask = (priv->bufnum_mask * 2) + 1;
+
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] driver: mtd: ifc: update bufnum mask for ver >= 2.0.0
2017-06-09 10:57 [PATCH] driver: mtd: ifc: update bufnum mask for ver >= 2.0.0 Prabhakar Kushwaha
@ 2017-06-20 7:21 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2017-06-20 7:21 UTC (permalink / raw)
To: Prabhakar Kushwaha; +Cc: linux-mtd, oss, computersforpeace, dedekind1
Hi,
Subject prefix should be "mtd: nand: ifc".
On Fri, 9 Jun 2017 16:27:37 +0530
Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com> wrote:
> Bufnum mask is used to calculate page position in the internal SRAM.
>
> As IFC version 2.0.0 has 16KB of internal SRAM as compared to older
> versions which had 8KB. Hence bufnum mask needs to be updated.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
> drivers/mtd/nand/fsl_ifc_nand.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c
> index eca269d..785e9ee 100644
> --- a/drivers/mtd/nand/fsl_ifc_nand.c
> +++ b/drivers/mtd/nand/fsl_ifc_nand.c
> @@ -907,6 +907,9 @@ static int fsl_ifc_chip_init(struct fsl_ifc_mtd *priv)
> if (ctrl->version >= FSL_IFC_VERSION_1_1_0)
> fsl_ifc_sram_init(priv);
>
Can you add a comment explaining why this is done (just put the content
of the commit message here).
> + if (ctrl->version >= FSL_IFC_VERSION_2_0_0)
> + priv->bufnum_mask = (priv->bufnum_mask * 2) + 1;
> +
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-20 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 10:57 [PATCH] driver: mtd: ifc: update bufnum mask for ver >= 2.0.0 Prabhakar Kushwaha
2017-06-20 7:21 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox