* [PATCH] ubi: fastmap: clean up the initialization of pointer p
@ 2017-10-29 13:14 Colin King
2017-10-30 8:28 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-29 13:14 UTC (permalink / raw)
To: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, Boris Brezillon, Marek Vasut, Cyrille Pitchen,
linux-mtd
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer p is being initialized with one value and a few lines
later being set to a newer replacement value. Clean up the code by
using the latter assignment to p as the initial value. Cleans up
clang warning:
drivers/mtd/ubi/fastmap.c:217:19: warning: Value stored to 'p'
during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mtd/ubi/fastmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index 5a832bc79b1b..9be4b94e83ad 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -214,9 +214,8 @@ static void assign_aeb_to_av(struct ubi_attach_info *ai,
struct ubi_ainf_volume *av)
{
struct ubi_ainf_peb *tmp_aeb;
- struct rb_node **p = &ai->volumes.rb_node, *parent = NULL;
+ struct rb_node **p = &av->root.rb_node, *parent = NULL;
- p = &av->root.rb_node;
while (*p) {
parent = *p;
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ubi: fastmap: clean up the initialization of pointer p
2017-10-29 13:14 [PATCH] ubi: fastmap: clean up the initialization of pointer p Colin King
@ 2017-10-30 8:28 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2017-10-30 8:28 UTC (permalink / raw)
To: Colin King
Cc: Artem Bityutskiy, Richard Weinberger, David Woodhouse,
Brian Norris, Marek Vasut, Cyrille Pitchen, linux-mtd,
kernel-janitors, linux-kernel
On Sun, 29 Oct 2017 13:14:26 +0000
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer p is being initialized with one value and a few lines
> later being set to a newer replacement value. Clean up the code by
> using the latter assignment to p as the initial value. Cleans up
> clang warning:
>
> drivers/mtd/ubi/fastmap.c:217:19: warning: Value stored to 'p'
> during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/ubi/fastmap.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index 5a832bc79b1b..9be4b94e83ad 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -214,9 +214,8 @@ static void assign_aeb_to_av(struct ubi_attach_info *ai,
> struct ubi_ainf_volume *av)
> {
> struct ubi_ainf_peb *tmp_aeb;
> - struct rb_node **p = &ai->volumes.rb_node, *parent = NULL;
> + struct rb_node **p = &av->root.rb_node, *parent = NULL;
>
> - p = &av->root.rb_node;
> while (*p) {
> parent = *p;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-30 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-29 13:14 [PATCH] ubi: fastmap: clean up the initialization of pointer p Colin King
2017-10-30 8:28 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox