Re: [PATCH v3] mtd: spi-nor: add support for ISSI is25lp128

[Angelo Dureghello <angelo@sysam.it>]

Hi Cyrille,

thanks for reviewing,

On Wed, Nov 29, 2017 at 11:58:37AM +0100, Cyrille Pitchen wrote:
> Hi Angelo,
> 
> Le 19/11/2017 à 00:48, Angelo Dureghello a écrit :
> > Add support for ISSI is25lp128 spi nor flash.
> > 
> > Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> > ---
> > Changes for v2:
> >    - add commit message.
> > Changes for v3:
> >    - add SPI_NOR_DUAL_READ flag.
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 19c000722cbc..b987353440ea 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {
> >  
> >  	/* ISSI */
> >  	{ "is25cd512", INFO(0x7f9d20, 0, 32 * 1024,   2, SECT_4K) },
> > +	{ "is25lp128", INFO(0x9d6018, 0, 64 * 1024,   256,
> 
> If you don't mind, I will align figures in the column for the number of
> sectors before applying your patch.
> 
> Otherwise, it looks good.
> 
Feel free to realign the code as you prefer, or if you prefer i can
also send v4.

> Best regards,
> 
> Cyrille
> > +			SECT_4K | SPI_NOR_DUAL_READ) },
> >  
Best regards,
Angelo Dureghello

> >  	/* Macronix */
> >  	{ "mx25l512e",   INFO(0xc22010, 0, 64 * 1024,   1, SECT_4K) },
> > 
>