* [PATCH v3] mtd: spi-nor: add support for ISSI is25lp128
@ 2017-11-18 23:48 Angelo Dureghello
2017-11-29 10:58 ` Cyrille Pitchen
0 siblings, 1 reply; 4+ messages in thread
From: Angelo Dureghello @ 2017-11-18 23:48 UTC (permalink / raw)
To: linux-mtd, boris.brezillon, cyrille.pitchen
Add support for ISSI is25lp128 spi nor flash.
Signed-off-by: Angelo Dureghello <angelo@sysam.it>
---
Changes for v2:
- add commit message.
Changes for v3:
- add SPI_NOR_DUAL_READ flag.
---
drivers/mtd/spi-nor/spi-nor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 19c000722cbc..b987353440ea 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {
/* ISSI */
{ "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) },
+ { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
+ SECT_4K | SPI_NOR_DUAL_READ) },
/* Macronix */
{ "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mtd: spi-nor: add support for ISSI is25lp128
2017-11-18 23:48 [PATCH v3] mtd: spi-nor: add support for ISSI is25lp128 Angelo Dureghello
@ 2017-11-29 10:58 ` Cyrille Pitchen
2017-11-29 11:05 ` Cyrille Pitchen
2017-11-29 11:34 ` Angelo Dureghello
0 siblings, 2 replies; 4+ messages in thread
From: Cyrille Pitchen @ 2017-11-29 10:58 UTC (permalink / raw)
To: Angelo Dureghello, linux-mtd, boris.brezillon
Hi Angelo,
Le 19/11/2017 à 00:48, Angelo Dureghello a écrit :
> Add support for ISSI is25lp128 spi nor flash.
>
> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> ---
> Changes for v2:
> - add commit message.
> Changes for v3:
> - add SPI_NOR_DUAL_READ flag.
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 19c000722cbc..b987353440ea 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {
>
> /* ISSI */
> { "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) },
> + { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
If you don't mind, I will align figures in the column for the number of
sectors before applying your patch.
Otherwise, it looks good.
Best regards,
Cyrille
> + SECT_4K | SPI_NOR_DUAL_READ) },
>
> /* Macronix */
> { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mtd: spi-nor: add support for ISSI is25lp128
2017-11-29 10:58 ` Cyrille Pitchen
@ 2017-11-29 11:05 ` Cyrille Pitchen
2017-11-29 11:34 ` Angelo Dureghello
1 sibling, 0 replies; 4+ messages in thread
From: Cyrille Pitchen @ 2017-11-29 11:05 UTC (permalink / raw)
To: Angelo Dureghello, linux-mtd, boris.brezillon
Le 29/11/2017 à 11:58, Cyrille Pitchen a écrit :
> Hi Angelo,
>
> Le 19/11/2017 à 00:48, Angelo Dureghello a écrit :
>> Add support for ISSI is25lp128 spi nor flash.
>>
>> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
Applied to the spi-nor/next branch of l2-mtd
Thanks
>> ---
>> Changes for v2:
>> - add commit message.
>> Changes for v3:
>> - add SPI_NOR_DUAL_READ flag.
>> ---
>> drivers/mtd/spi-nor/spi-nor.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>> index 19c000722cbc..b987353440ea 100644
>> --- a/drivers/mtd/spi-nor/spi-nor.c
>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>> @@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {
>>
>> /* ISSI */
>> { "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) },
>> + { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
>
> If you don't mind, I will align figures in the column for the number of
> sectors before applying your patch.
>
> Otherwise, it looks good.
>
> Best regards,
>
> Cyrille
>> + SECT_4K | SPI_NOR_DUAL_READ) },
>>
>> /* Macronix */
>> { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },
>>
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] mtd: spi-nor: add support for ISSI is25lp128
2017-11-29 10:58 ` Cyrille Pitchen
2017-11-29 11:05 ` Cyrille Pitchen
@ 2017-11-29 11:34 ` Angelo Dureghello
1 sibling, 0 replies; 4+ messages in thread
From: Angelo Dureghello @ 2017-11-29 11:34 UTC (permalink / raw)
To: Cyrille Pitchen; +Cc: linux-mtd, boris.brezillon
Hi Cyrille,
thanks for reviewing,
On Wed, Nov 29, 2017 at 11:58:37AM +0100, Cyrille Pitchen wrote:
> Hi Angelo,
>
> Le 19/11/2017 à 00:48, Angelo Dureghello a écrit :
> > Add support for ISSI is25lp128 spi nor flash.
> >
> > Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> > ---
> > Changes for v2:
> > - add commit message.
> > Changes for v3:
> > - add SPI_NOR_DUAL_READ flag.
> > ---
> > drivers/mtd/spi-nor/spi-nor.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 19c000722cbc..b987353440ea 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -1005,6 +1005,8 @@ static const struct flash_info spi_nor_ids[] = {
> >
> > /* ISSI */
> > { "is25cd512", INFO(0x7f9d20, 0, 32 * 1024, 2, SECT_4K) },
> > + { "is25lp128", INFO(0x9d6018, 0, 64 * 1024, 256,
>
> If you don't mind, I will align figures in the column for the number of
> sectors before applying your patch.
>
> Otherwise, it looks good.
>
Feel free to realign the code as you prefer, or if you prefer i can
also send v4.
> Best regards,
>
> Cyrille
> > + SECT_4K | SPI_NOR_DUAL_READ) },
> >
Best regards,
Angelo Dureghello
> > /* Macronix */
> > { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-29 11:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-18 23:48 [PATCH v3] mtd: spi-nor: add support for ISSI is25lp128 Angelo Dureghello
2017-11-29 10:58 ` Cyrille Pitchen
2017-11-29 11:05 ` Cyrille Pitchen
2017-11-29 11:34 ` Angelo Dureghello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox