* [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text
@ 2017-11-17 11:09 Sascha Hauer
2017-11-17 11:34 ` Fabio Estevam
2017-11-30 21:34 ` Boris Brezillon
0 siblings, 2 replies; 4+ messages in thread
From: Sascha Hauer @ 2017-11-17 11:09 UTC (permalink / raw)
To: linux-mtd
Cc: Han Xu, Boris Brezillon, Richard Weinberger, kernel, Sascha Hauer
The GPMI nand Kconfig help texts mentions that the GPMI nand driver
might conflict with SD cards. The only conflict there might really
be is that both controllers use the same pins, but this is resolved
by the pincontroller setup in the device tree. In any way the GPMI
driver can safely be enabled, the text is just wrong. Remove it.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mtd/nand/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 3f2036f31da4..8f4c288cf9f1 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -373,9 +373,7 @@ config MTD_NAND_GPMI_NAND
Enables NAND Flash support for IMX23, IMX28 or IMX6.
The GPMI controller is very powerful, with the help of BCH
module, it can do the hardware ECC. The GPMI supports several
- NAND flashs at the same time. The GPMI may conflicts with other
- block, such as SD card. So pay attention to it when you enable
- the GPMI.
+ NAND flashs at the same time.
config MTD_NAND_BRCMNAND
tristate "Broadcom STB NAND controller"
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text
2017-11-17 11:09 [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text Sascha Hauer
@ 2017-11-17 11:34 ` Fabio Estevam
2017-11-17 16:46 ` Han Xu
2017-11-30 21:34 ` Boris Brezillon
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2017-11-17 11:34 UTC (permalink / raw)
To: Sascha Hauer
Cc: linux-mtd@lists.infradead.org, Han Xu, Richard Weinberger,
Sascha Hauer, Boris Brezillon
On Fri, Nov 17, 2017 at 9:09 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> The GPMI nand Kconfig help texts mentions that the GPMI nand driver
> might conflict with SD cards. The only conflict there might really
> be is that both controllers use the same pins, but this is resolved
> by the pincontroller setup in the device tree. In any way the GPMI
> driver can safely be enabled, the text is just wrong. Remove it.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text
2017-11-17 11:34 ` Fabio Estevam
@ 2017-11-17 16:46 ` Han Xu
0 siblings, 0 replies; 4+ messages in thread
From: Han Xu @ 2017-11-17 16:46 UTC (permalink / raw)
To: Fabio Estevam, Sascha Hauer
Cc: linux-mtd@lists.infradead.org, Richard Weinberger, Sascha Hauer,
Boris Brezillon
________________________________________
From: Fabio Estevam <festevam@gmail.com>
Sent: Friday, November 17, 2017 5:34 AM
To: Sascha Hauer
Cc: linux-mtd@lists.infradead.org; Han Xu; Richard Weinberger; Sascha Hauer; Boris Brezillon
Subject: Re: [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text
On Fri, Nov 17, 2017 at 9:09 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> The GPMI nand Kconfig help texts mentions that the GPMI nand driver
> might conflict with SD cards. The only conflict there might really
> be is that both controllers use the same pins, but this is resolved
> by the pincontroller setup in the device tree. In any way the GPMI
> driver can safely be enabled, the text is just wrong. Remove it.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Han Xu <han.xu@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text
2017-11-17 11:09 [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text Sascha Hauer
2017-11-17 11:34 ` Fabio Estevam
@ 2017-11-30 21:34 ` Boris Brezillon
1 sibling, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2017-11-30 21:34 UTC (permalink / raw)
To: Sascha Hauer; +Cc: linux-mtd, Han Xu, Richard Weinberger, kernel
On Fri, 17 Nov 2017 12:09:12 +0100
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> The GPMI nand Kconfig help texts mentions that the GPMI nand driver
> might conflict with SD cards. The only conflict there might really
> be is that both controllers use the same pins, but this is resolved
> by the pincontroller setup in the device tree. In any way the GPMI
> driver can safely be enabled, the text is just wrong. Remove it.
Applied.
Thanks,
Boris
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mtd/nand/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 3f2036f31da4..8f4c288cf9f1 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -373,9 +373,7 @@ config MTD_NAND_GPMI_NAND
> Enables NAND Flash support for IMX23, IMX28 or IMX6.
> The GPMI controller is very powerful, with the help of BCH
> module, it can do the hardware ECC. The GPMI supports several
> - NAND flashs at the same time. The GPMI may conflicts with other
> - block, such as SD card. So pay attention to it when you enable
> - the GPMI.
> + NAND flashs at the same time.
>
> config MTD_NAND_BRCMNAND
> tristate "Broadcom STB NAND controller"
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-30 21:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-17 11:09 [PATCH] mtd: nand: gpmi-nand: Remove wrong Kconfig help text Sascha Hauer
2017-11-17 11:34 ` Fabio Estevam
2017-11-17 16:46 ` Han Xu
2017-11-30 21:34 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox