From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd <linux-mtd@lists.infradead.org>,
Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH 1/2] mtd: nand: denali: Avoid using ecc->code_buf as a temporary buffer
Date: Thu, 7 Dec 2017 21:18:43 +0100 [thread overview]
Message-ID: <20171207211843.4fd4bbbd@bbrezillon> (raw)
In-Reply-To: <CAK7LNARq_TPmkBZ_EkiWpze=-4QmCbUCb_KHdJhm2XSXVAqLzg@mail.gmail.com>
On Tue, 5 Dec 2017 21:37:45 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> 2017-12-05 20:09 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
> > ECC bytes are contiguous in the ->oob_poi buffer, which means we don't
> > have to copy them into the ->code_buf (here used as a temporary buffer)
> > before passing them to the nand_check_erased_ecc_chunk() function.
> >
> > This change will allow us to allocate ecc->{code,calc}_buf only when
> > ecc->calculate() or ecc->correct() is specified.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied those 2 patches.
Boris
>
> Thanks!
>
>
>
>
prev parent reply other threads:[~2017-12-07 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 11:09 [PATCH 1/2] mtd: nand: denali: Avoid using ecc->code_buf as a temporary buffer Boris Brezillon
2017-12-05 11:09 ` [PATCH 2/2] mtd: nand: Only allocate ecc->{calc, code}_buf when actually needed Boris Brezillon
2017-12-05 15:29 ` Masahiro Yamada
2017-12-05 12:37 ` [PATCH 1/2] mtd: nand: denali: Avoid using ecc->code_buf as a temporary buffer Masahiro Yamada
2017-12-07 20:18 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207211843.4fd4bbbd@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox