* [PATCH 1/2] mtd: qcom_nandc: Add a NULL check for devm_kasprintf()
@ 2018-01-05 20:02 Fabio Estevam
2018-01-05 20:02 ` [PATCH 2/2] mtd: brcmnand: " Fabio Estevam
2018-01-07 10:04 ` [PATCH 1/2] mtd: qcom_nandc: " Boris Brezillon
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2018-01-05 20:02 UTC (permalink / raw)
To: boris.brezillon
Cc: cyrille.pitchen, architt, linux-mtd, computersforpeace,
Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_kasprintf() may fail, so we should better add a NULL check
and propagate an error on failure.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/mtd/nand/qcom_nandc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c
index 245d0f3..3fe2ff8 100644
--- a/drivers/mtd/nand/qcom_nandc.c
+++ b/drivers/mtd/nand/qcom_nandc.c
@@ -2639,6 +2639,8 @@ static int qcom_nand_host_init(struct qcom_nand_controller *nandc,
nand_set_flash_node(chip, dn);
mtd->name = devm_kasprintf(dev, GFP_KERNEL, "qcom_nand.%d", host->cs);
+ if (!mtd->name)
+ return -ENOMEM;
mtd->owner = THIS_MODULE;
mtd->dev.parent = dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] mtd: brcmnand: Add a NULL check for devm_kasprintf()
2018-01-05 20:02 [PATCH 1/2] mtd: qcom_nandc: Add a NULL check for devm_kasprintf() Fabio Estevam
@ 2018-01-05 20:02 ` Fabio Estevam
2018-01-06 9:35 ` Boris Brezillon
2018-01-07 10:04 ` [PATCH 1/2] mtd: qcom_nandc: " Boris Brezillon
1 sibling, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2018-01-05 20:02 UTC (permalink / raw)
To: boris.brezillon
Cc: cyrille.pitchen, architt, linux-mtd, computersforpeace,
Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
devm_kasprintf() may fail, so we should better add a NULL check
and propagate an error on failure.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/mtd/nand/brcmnand/brcmnand.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
index 3310e14..8942aa6 100644
--- a/drivers/mtd/nand/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/brcmnand/brcmnand.c
@@ -2237,6 +2237,8 @@ static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)
nand_set_controller_data(chip, host);
mtd->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "brcmnand.%d",
host->cs);
+ if (!mtd->name)
+ return -ENOMEM;
mtd->owner = THIS_MODULE;
mtd->dev.parent = &pdev->dev;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: brcmnand: Add a NULL check for devm_kasprintf()
2018-01-05 20:02 ` [PATCH 2/2] mtd: brcmnand: " Fabio Estevam
@ 2018-01-06 9:35 ` Boris Brezillon
2018-01-06 20:40 ` Boris Brezillon
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2018-01-06 9:35 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, architt, computersforpeace, linux-mtd,
cyrille.pitchen
Hi Fabio,
The prefix should be "mtd: nand: brcmnand: ".
No need to resend, I'll fix it when applying.
Thanks,
Boris
On Fri, 5 Jan 2018 18:02:56 -0200
Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_kasprintf() may fail, so we should better add a NULL check
> and propagate an error on failure.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/mtd/nand/brcmnand/brcmnand.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index 3310e14..8942aa6 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -2237,6 +2237,8 @@ static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)
> nand_set_controller_data(chip, host);
> mtd->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "brcmnand.%d",
> host->cs);
> + if (!mtd->name)
> + return -ENOMEM;
> mtd->owner = THIS_MODULE;
> mtd->dev.parent = &pdev->dev;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] mtd: brcmnand: Add a NULL check for devm_kasprintf()
2018-01-06 9:35 ` Boris Brezillon
@ 2018-01-06 20:40 ` Boris Brezillon
0 siblings, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2018-01-06 20:40 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, architt, computersforpeace, linux-mtd,
cyrille.pitchen
On Sat, 6 Jan 2018 10:35:57 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> Hi Fabio,
>
> The prefix should be "mtd: nand: brcmnand: ".
>
> No need to resend, I'll fix it when applying.
>
> Thanks,
>
> Boris
>
> On Fri, 5 Jan 2018 18:02:56 -0200
> Fabio Estevam <festevam@gmail.com> wrote:
>
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> >
> > devm_kasprintf() may fail, so we should better add a NULL check
> > and propagate an error on failure.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied.
Thanks,
Boris
> > ---
> > drivers/mtd/nand/brcmnand/brcmnand.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> > index 3310e14..8942aa6 100644
> > --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> > +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> > @@ -2237,6 +2237,8 @@ static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn)
> > nand_set_controller_data(chip, host);
> > mtd->name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "brcmnand.%d",
> > host->cs);
> > + if (!mtd->name)
> > + return -ENOMEM;
> > mtd->owner = THIS_MODULE;
> > mtd->dev.parent = &pdev->dev;
> >
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] mtd: qcom_nandc: Add a NULL check for devm_kasprintf()
2018-01-05 20:02 [PATCH 1/2] mtd: qcom_nandc: Add a NULL check for devm_kasprintf() Fabio Estevam
2018-01-05 20:02 ` [PATCH 2/2] mtd: brcmnand: " Fabio Estevam
@ 2018-01-07 10:04 ` Boris Brezillon
1 sibling, 0 replies; 5+ messages in thread
From: Boris Brezillon @ 2018-01-07 10:04 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, architt, computersforpeace, linux-mtd,
cyrille.pitchen
On Fri, 5 Jan 2018 18:02:55 -0200
Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> devm_kasprintf() may fail, so we should better add a NULL check
> and propagate an error on failure.
Applied (also fixed the subject prefix).
Thanks,
Boris
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> drivers/mtd/nand/qcom_nandc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c
> index 245d0f3..3fe2ff8 100644
> --- a/drivers/mtd/nand/qcom_nandc.c
> +++ b/drivers/mtd/nand/qcom_nandc.c
> @@ -2639,6 +2639,8 @@ static int qcom_nand_host_init(struct qcom_nand_controller *nandc,
>
> nand_set_flash_node(chip, dn);
> mtd->name = devm_kasprintf(dev, GFP_KERNEL, "qcom_nand.%d", host->cs);
> + if (!mtd->name)
> + return -ENOMEM;
> mtd->owner = THIS_MODULE;
> mtd->dev.parent = dev;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-07 10:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-05 20:02 [PATCH 1/2] mtd: qcom_nandc: Add a NULL check for devm_kasprintf() Fabio Estevam
2018-01-05 20:02 ` [PATCH 2/2] mtd: brcmnand: " Fabio Estevam
2018-01-06 9:35 ` Boris Brezillon
2018-01-06 20:40 ` Boris Brezillon
2018-01-07 10:04 ` [PATCH 1/2] mtd: qcom_nandc: " Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox