From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, Han Xu <han.xu@nxp.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Stefan Agner <stefan@agner.ch>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
juliensu@mxic.com.tw, jocelyncarroue@macronix.com
Subject: Re: [PATCH v3 03/14] mtd: rawnand: mxc: rename the local ->set/get_features() implementation
Date: Fri, 2 Mar 2018 23:38:03 +0100 [thread overview]
Message-ID: <20180302233803.642e4939@bbrezillon> (raw)
In-Reply-To: <20180302142422.2543-4-miquel.raynal@bootlin.com>
On Fri, 2 Mar 2018 15:24:11 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> MXC NAND driver embeds its own implementation of the
> ->set/get_features() hooks. These hooks were once flagged "onfi" but a
> lot of not-ONFI compliant NAND chips use it so they have been renamed
> to remove the "onfi" relationship. Rename these functions the same way
> for consistency.
Should be squashed in patch 2 IMO.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> drivers/mtd/nand/raw/mxc_nand.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/mxc_nand.c b/drivers/mtd/nand/raw/mxc_nand.c
> index d331305f45c1..61501654e708 100644
> --- a/drivers/mtd/nand/raw/mxc_nand.c
> +++ b/drivers/mtd/nand/raw/mxc_nand.c
> @@ -1421,9 +1421,8 @@ static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
> }
> }
>
> -static int mxc_nand_onfi_set_features(struct mtd_info *mtd,
> - struct nand_chip *chip, int addr,
> - u8 *subfeature_param)
> +static int mxc_nand_set_features(struct mtd_info *mtd, struct nand_chip *chip,
> + int addr, u8 *subfeature_param)
> {
> struct nand_chip *nand_chip = mtd_to_nand(mtd);
> struct mxc_nand_host *host = nand_get_controller_data(nand_chip);
> @@ -1447,9 +1446,8 @@ static int mxc_nand_onfi_set_features(struct mtd_info *mtd,
> return 0;
> }
>
> -static int mxc_nand_onfi_get_features(struct mtd_info *mtd,
> - struct nand_chip *chip, int addr,
> - u8 *subfeature_param)
> +static int mxc_nand_get_features(struct mtd_info *mtd, struct nand_chip *chip,
> + int addr, u8 *subfeature_param)
> {
> struct nand_chip *nand_chip = mtd_to_nand(mtd);
> struct mxc_nand_host *host = nand_get_controller_data(nand_chip);
> @@ -1752,8 +1750,8 @@ static int mxcnd_probe(struct platform_device *pdev)
> this->read_word = mxc_nand_read_word;
> this->write_buf = mxc_nand_write_buf;
> this->read_buf = mxc_nand_read_buf;
> - this->set_features = mxc_nand_onfi_set_features;
> - this->get_features = mxc_nand_onfi_get_features;
> + this->set_features = mxc_nand_set_features;
> + this->get_features = mxc_nand_get_features;
>
> host->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(host->clk))
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-02 22:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 14:24 [PATCH v3 00/14] Improve timings handling in the NAND framework Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 01/14] mtd: rawnand: rename default ->onfi_get/set_features() implementations Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 02/14] mtd: rawnand: rename SET/GET FEATURES related functions Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 03/14] mtd: rawnand: mxc: rename the local ->set/get_features() implementation Miquel Raynal
2018-03-02 22:38 ` Boris Brezillon [this message]
2018-03-02 14:24 ` [PATCH v3 04/14] mtd: rawnand: move calls to ->select_chip() in nand_setup_data_interface() Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 05/14] mtd: rawnand: check ONFI timings have been acked by the chip Miquel Raynal
2018-03-02 22:17 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 06/14] mtd: rawnand: avoid setting again the timings to mode 0 after a reset Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 07/14] mtd: rawnand: use wrappers to call onfi GET/SET_FEATURES Miquel Raynal
2018-03-02 22:40 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 08/14] mtd: rawnand: mxc: remove useless checks in GET/SET_FEATURES functions Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 09/14] mtd: rawnand: prepare the removal of ONFI/JEDEC parameter pages Miquel Raynal
2018-03-12 19:00 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 10/14] mtd: rawnand: prepare the removal of the ONFI parameter page Miquel Raynal
2018-03-12 19:20 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 11/14] mtd: rawnand: allow vendors to declare (un)supported features Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 12/14] mtd: rawnand: macronix: nack the support of changing timings for one chip Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 13/14] mtd: rawnand: get rid of the JEDEC parameter page in nand_chip Miquel Raynal
2018-03-12 19:23 ` Boris Brezillon
2018-03-12 19:24 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 14/14] mtd: rawnand: get rid of the ONFI " Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302233803.642e4939@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=han.xu@nxp.com \
--cc=jocelyncarroue@macronix.com \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox