From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
jocelyncarroue@macronix.com, juliensu@mxic.com.tw,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stefan Agner <stefan@agner.ch>,
linux-mtd@lists.infradead.org,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Han Xu <han.xu@nxp.com>
Subject: Re: [PATCH v3 10/14] mtd: rawnand: prepare the removal of the ONFI parameter page
Date: Mon, 12 Mar 2018 20:20:49 +0100 [thread overview]
Message-ID: <20180312202049.287a96df@bbrezillon> (raw)
In-Reply-To: <20180302142422.2543-11-miquel.raynal@bootlin.com>
On Fri, 2 Mar 2018 15:24:18 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 1af0bff58ff4..81236b3fbc6f 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -429,9 +429,23 @@ struct nand_jedec_params {
> __le16 crc;
> } __packed;
>
> +struct onfi_params {
> + u16 t_prog;
> + u16 t_bers;
> + u16 t_r;
> + u16 t_ccs;
> + u16 async_timing_mode;
> + u16 vendor_revision;
> + u8 vendor[88];
> +};
Kernel-doc missing here.
> +
> struct nand_parameters {
> + /* Generic parameters */
> char model[100];
> bool supports_set_get_features;
> +
> + /* ONFI parameters */
> + struct onfi_params onfi_params;
Why not name the field onfi instead of onfi_params?
> };
--
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-03-12 19:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 14:24 [PATCH v3 00/14] Improve timings handling in the NAND framework Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 01/14] mtd: rawnand: rename default ->onfi_get/set_features() implementations Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 02/14] mtd: rawnand: rename SET/GET FEATURES related functions Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 03/14] mtd: rawnand: mxc: rename the local ->set/get_features() implementation Miquel Raynal
2018-03-02 22:38 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 04/14] mtd: rawnand: move calls to ->select_chip() in nand_setup_data_interface() Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 05/14] mtd: rawnand: check ONFI timings have been acked by the chip Miquel Raynal
2018-03-02 22:17 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 06/14] mtd: rawnand: avoid setting again the timings to mode 0 after a reset Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 07/14] mtd: rawnand: use wrappers to call onfi GET/SET_FEATURES Miquel Raynal
2018-03-02 22:40 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 08/14] mtd: rawnand: mxc: remove useless checks in GET/SET_FEATURES functions Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 09/14] mtd: rawnand: prepare the removal of ONFI/JEDEC parameter pages Miquel Raynal
2018-03-12 19:00 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 10/14] mtd: rawnand: prepare the removal of the ONFI parameter page Miquel Raynal
2018-03-12 19:20 ` Boris Brezillon [this message]
2018-03-02 14:24 ` [PATCH v3 11/14] mtd: rawnand: allow vendors to declare (un)supported features Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 12/14] mtd: rawnand: macronix: nack the support of changing timings for one chip Miquel Raynal
2018-03-02 14:24 ` [PATCH v3 13/14] mtd: rawnand: get rid of the JEDEC parameter page in nand_chip Miquel Raynal
2018-03-12 19:23 ` Boris Brezillon
2018-03-12 19:24 ` Boris Brezillon
2018-03-02 14:24 ` [PATCH v3 14/14] mtd: rawnand: get rid of the ONFI " Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312202049.287a96df@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=han.xu@nxp.com \
--cc=jocelyncarroue@macronix.com \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox