From: Boris Brezillon <boris.brezillon@bootlin.com>
To: IKEGAMI Tokunori <ikegami@allied-telesis.co.jp>
Cc: "boris.brezillon@free-electrons.com"
<boris.brezillon@free-electrons.com>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"richard@nod.at" <richard@nod.at>,
Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
"PACKHAM Chris" <chris.packham@alliedtelesis.co.nz>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"cyrille.pitchen@wedev4u.fr" <cyrille.pitchen@wedev4u.fr>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>
Subject: Re: [PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase
Date: Mon, 14 May 2018 11:44:40 +0200 [thread overview]
Message-ID: <20180514114440.54190a34@bbrezillon> (raw)
In-Reply-To: <TY1PR01MB09540ADA613B8D72668B9E64DC9C0@TY1PR01MB0954.jpnprd01.prod.outlook.com>
On Mon, 14 May 2018 09:32:01 +0000
IKEGAMI Tokunori <ikegami@allied-telesis.co.jp> wrote:
> Hi Boris-san,
>
> Thanks for your reviewing.
>
> > Can you please use git send-email when you send your patch series, so
> > that they are properly threaded.
>
> Yes I have just resend the v5 patch series by using git send-email.
> But the source address is set as smtpuser <smtpuser@allied-telesis.co.jp>.
> This is required on our company mail system currently.
> But please do not reply to the address but reply to my email address below.
> Tokunori Ikegami <ikegami at allied-telesis.co.jp>
There's still a problem: the patches do not appear as a thread. Can you
paste the git send-email command you use?
>
> Note: I am asking to resolve this issue to our IS department currently.
>
> I have just resend the patch series so please review the last patch series.
> Very sorry for resending the patch series many times.
It seems that nothing has changed, so nothing more to review on my
side. And I'm still not entirely convinced by the fix, but if nobody
complains, I'll apply it. BTW, the changelog is really not clear, you
should have something like:
Changes since v4:
- blabla
- blablabla
Changes since v3:
- blabla
- blablabla
Changes since v2:
- blabla
- blablabla
Changes since v1:
- blabla
- blablabla
next prev parent reply other threads:[~2018-05-14 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 2:11 [PATCH v5 0/2] mtd: cfi_cmdset_0002: Changes to retry for flash erase IKEGAMI Tokunori
2018-05-14 7:12 ` Boris Brezillon
2018-05-14 9:32 ` IKEGAMI Tokunori
2018-05-14 9:44 ` Boris Brezillon [this message]
2018-05-14 10:23 ` IKEGAMI Tokunori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514114440.54190a34@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=Joakim.Tjernlund@infinera.com \
--cc=boris.brezillon@free-electrons.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=ikegami@allied-telesis.co.jp \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox