public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH v2 2/4] mtd: rawnand: NAND controller write protect
@ 2023-10-12  0:41 dregan
  2023-10-12  7:08 ` Miquel Raynal
  0 siblings, 1 reply; 2+ messages in thread
From: dregan @ 2023-10-12  0:41 UTC (permalink / raw)
  To: Miquel Raynal, bcm-kernel-feedback-list, linux-mtd, f.fainelli,
	rafal, joel.peshkin, computersforpeace, dan.beygelman,
	william.zhang, frieder.schrempf, linux-kernel, vigneshr, richard,
	bbrezillon, kdasu.kdev, dregan, JaimeLiao, Arseniy Krasnov,
	Adam Borowski

Allow NAND controller to be responsible for write protect pin
handling during fast path and exec_op destructive operation
when controller_wp flag is set.

Signed-off-by: David Regan <dregan@mail.com>

---

Changes in v2: none
---
 drivers/mtd/nand/raw/nand_base.c | 4 ++++
 include/linux/mtd/rawnand.h      | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 47cc2c35153b..38ed0ced5b8e 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -367,6 +367,10 @@ static int nand_check_wp(struct nand_chip *chip)
 	if (chip->options & NAND_BROKEN_XD)
 		return 0;

+	/* controller responsible for NAND write protect */
+	if (chip->controller->controller_wp)
+		return 0;
+
 	/* Check the WP bit */
 	ret = nand_status_op(chip, &status);
 	if (ret)
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index 31aceda8616c..f03b9d7f48b8 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -1111,6 +1111,7 @@ struct nand_controller_ops {
  *			the bus without restarting an entire read operation nor
  *			changing the column.
  * @supported_op.cont_read: The controller supports sequential cache reads.
+ * @controller_wp:	controller responsible for NAND write protect.
  */
 struct nand_controller {
 	struct mutex lock;
@@ -1119,6 +1120,7 @@ struct nand_controller {
 		unsigned int data_only_read: 1;
 		unsigned int cont_read: 1;
 	} supported_op;
+	bool controller_wp;
 };

 static inline void nand_controller_init(struct nand_controller *nfc)
--
2.37.3



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/4] mtd: rawnand: NAND controller write protect
  2023-10-12  0:41 [PATCH v2 2/4] mtd: rawnand: NAND controller write protect dregan
@ 2023-10-12  7:08 ` Miquel Raynal
  0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2023-10-12  7:08 UTC (permalink / raw)
  To: dregan
  Cc: bcm-kernel-feedback-list, linux-mtd, f.fainelli, rafal,
	joel.peshkin, computersforpeace, dan.beygelman, william.zhang,
	frieder.schrempf, linux-kernel, vigneshr, richard, bbrezillon,
	kdasu.kdev, JaimeLiao, Arseniy Krasnov, Adam Borowski

Hi dregan@mail.com,

dregan@mail.com wrote on Thu, 12 Oct 2023 02:41:10 +0200:

> Allow NAND controller to be responsible for write protect pin
> handling during fast path and exec_op destructive operation
> when controller_wp flag is set.
> 
> Signed-off-by: David Regan <dregan@mail.com>
> 
> ---
> 
> Changes in v2: none
> ---
>  drivers/mtd/nand/raw/nand_base.c | 4 ++++
>  include/linux/mtd/rawnand.h      | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 47cc2c35153b..38ed0ced5b8e 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -367,6 +367,10 @@ static int nand_check_wp(struct nand_chip *chip)
>  	if (chip->options & NAND_BROKEN_XD)
>  		return 0;
> 
> +	/* controller responsible for NAND write protect */
> +	if (chip->controller->controller_wp)
> +		return 0;
> +
>  	/* Check the WP bit */
>  	ret = nand_status_op(chip, &status);
>  	if (ret)
> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 31aceda8616c..f03b9d7f48b8 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -1111,6 +1111,7 @@ struct nand_controller_ops {
>   *			the bus without restarting an entire read operation nor
>   *			changing the column.
>   * @supported_op.cont_read: The controller supports sequential cache reads.
> + * @controller_wp:	controller responsible for NAND write protect.

			The controller is in charge of handling the WP pin

>   */
>  struct nand_controller {
>  	struct mutex lock;
> @@ -1119,6 +1120,7 @@ struct nand_controller {
>  		unsigned int data_only_read: 1;
>  		unsigned int cont_read: 1;
>  	} supported_op;
> +	bool controller_wp;
>  };
> 
>  static inline void nand_controller_init(struct nand_controller *nfc)
> --
> 2.37.3
> 
> 


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-12  7:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-12  0:41 [PATCH v2 2/4] mtd: rawnand: NAND controller write protect dregan
2023-10-12  7:08 ` Miquel Raynal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox