From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Daniel Golle <daniel@makrotopia.org>,
Jean Delvare <jdelvare@suse.de>,
Christophe Kerello <christophe.kerello@foss.st.com>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
Johan Jonker <jbx6244@gmail.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
Alexander Sverdlin <alexander.sverdlin@gmail.com>
Subject: Re: [PATCH v5 19/39] mtd: rawnand: add support for ts72xx
Date: Fri, 8 Dec 2023 12:33:38 +0100 [thread overview]
Message-ID: <20231208123338.37f1a141@xps-13> (raw)
In-Reply-To: <6bc0cf7ea58fae2e6a3765f673a777788d465984.camel@maquefel.me>
Hi Nikita,
> > > + for (i = 0; i < instr->ctx.addr.naddrs; i++)
> > > + iowrite8(instr->ctx.addr.addrs[i], data-
> > > >base);
> >
> > iowrite8_rep() ?
> >
> > > + case NAND_OP_DATA_IN_INSTR:
> > > + ioread8_rep(data->base, instr->ctx.data.buf.in,
> > > instr->ctx.data.len);
> >
> > Hehe, you are even using it...
> >
> > ...
> >
> > > + if (instr->delay_ns)
> >
> > What will happen if you drop this check?
> >
> > > + ndelay(instr->delay_ns);
>
> No idea! I was asked to keep it by Miquel:
Your controller is very simple and just queues whatever command you
ask, precisely when you ask it to do so. But the NAND bus is a bit more
complex and there are minimum delays between certain instructions. This
delay is meant to respect that. Sometimes it will be 0, and sometimes
not. It depends what NAND op you do. You can check the value of these
delays in the core.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-12-08 11:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 8:59 [PATCH v5 00/39] ep93xx device tree conversion Nikita Shubin via B4 Relay
2023-11-22 8:59 ` [PATCH v5 18/39] dt-bindings: mtd: Add ts7200 nand-controller Nikita Shubin via B4 Relay
2023-11-22 11:02 ` Rob Herring
2023-11-22 8:59 ` [PATCH v5 19/39] mtd: rawnand: add support for ts72xx Nikita Shubin via B4 Relay
2023-11-22 12:24 ` Andy Shevchenko
2023-11-22 13:08 ` Miquel Raynal
2023-12-08 11:24 ` Nikita Shubin
2023-12-08 11:33 ` Miquel Raynal [this message]
2023-11-22 10:26 ` [PATCH v5 00/39] ep93xx device tree conversion Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208123338.37f1a141@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=alexander.sverdlin@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=christophe.kerello@foss.st.com \
--cc=daniel@makrotopia.org \
--cc=jbx6244@gmail.com \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=nikita.shubin@maquefel.me \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox