Re: [PATCH v5 19/39] mtd: rawnand: add support for ts72xx

From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikita Shubin <nikita.shubin@maquefel.me>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Daniel Golle <daniel@makrotopia.org>,
	Jean Delvare <jdelvare@suse.de>,
	Christophe Kerello <christophe.kerello@foss.st.com>,
	Chris Packham <chris.packham@alliedtelesis.co.nz>,
	Johan Jonker <jbx6244@gmail.com>,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>
Subject: Re: [PATCH v5 19/39] mtd: rawnand: add support for ts72xx
Date: Wed, 22 Nov 2023 14:24:24 +0200	[thread overview]
Message-ID: <ZV3y-IJ7JSD3fJeI@smile.fi.intel.com> (raw)
In-Reply-To: <20231122-ep93xx-v5-19-d59a76d5df29@maquefel.me>

On Wed, Nov 22, 2023 at 11:59:57AM +0300, Nikita Shubin wrote:
> Technologic Systems has it's own nand controller implementation in CPLD.

...

> +static int ts72xx_nand_attach_chip(struct nand_chip *chip)
> +{
> +	switch (chip->ecc.engine_type) {
> +	case NAND_ECC_ENGINE_TYPE_SOFT:
> +		if (chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN)
> +			chip->ecc.algo = NAND_ECC_ALGO_HAMMING;
> +		chip->ecc.algo = NAND_ECC_ALGO_HAMMING;
> +		break;
> +	case NAND_ECC_ENGINE_TYPE_ON_HOST:
> +		return -EINVAL;

> +	default:
> +		break;
> +	}
> +
> +	return 0;

Move this to default.

> +}

...

> +		for (i = 0; i < instr->ctx.addr.naddrs; i++)
> +			iowrite8(instr->ctx.addr.addrs[i], data->base);

iowrite8_rep() ?

> +	case NAND_OP_DATA_IN_INSTR:
> +		ioread8_rep(data->base, instr->ctx.data.buf.in, instr->ctx.data.len);

Hehe, you are even using it...

...

> +	if (instr->delay_ns)

What will happen if you drop this check?

> +		ndelay(instr->delay_ns);

...

> +	int ret;
> +
> +	ret = mtd_device_unregister(nand_to_mtd(chip));
> +	WARN_ON(ret);

Is this a requirement by MTD to have return value being checked?

-- 
With Best Regards,
Andy Shevchenko

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/