public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mohamed Sardi <moh.sardi@skyhighmemory.com>
Cc: "Kyeongrho.Kim" <kr.kim@skyhighmemory.com>,
	"tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
	"p.yadav@ti.com" <p.yadav@ti.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"richard@nod.at" <richard@nod.at>,
	Mohammad Nada <Mohammad.nada@skyhighmemory.com>,
	"Changsub.Shim" <changsub.shim@skyhighmemory.com>
Subject: Re: [SkyHigh Memory SPI NAND Driver]
Date: Wed, 24 Jan 2024 18:07:16 +0100	[thread overview]
Message-ID: <20240124180716.71e26b8c@xps-13> (raw)
In-Reply-To: <880CF70D-DC61-4E18-9A31-48A82A45CA3E@skyhighmemory.com>

Hi Mohamed,

moh.sardi@skyhighmemory.com wrote on Tue, 23 Jan 2024 01:01:53 +0000:

> Hello Miquel,
> 
> I have a question for bad block marking and checking on Linux... and ECC.
> 
> Do you know how bad block marking is done?
> 
> 1) Bad Block Marking: Are your writing non FF on the first 2 bytes of the OOB? Do you keep Device ECC ON or OFF?
> 2) Bad block Checking: Do you read the first 2 bytes of the OOB with ECC OFF or do you keep ECC ON?

In the raw NAND world, for legacy reasons these checks and writes are
done with the correction engine enabled. But I believe you are
interested into the SPI-NAND side only, and in this case the ECC is
always disabled:

Marking:
https://elixir.bootlin.com/linux/v6.8-rc1/source/drivers/mtd/nand/spi/core.c#L768
Checking:
https://elixir.bootlin.com/linux/v6.8-rc1/source/drivers/mtd/nand/spi/core.c#L733

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-01-24 17:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7C13C29F-DBE0-494F-8BA6-99BB68FD08AF@skyhighmemory.com>
2024-01-08 13:47 ` [SkyHigh Memory SPI NAND Driver] Miquel Raynal
2024-01-08 19:05   ` Mohamed Sardi
     [not found]   ` <SE2P216MB2102316F0F2D8134C755C37283682@SE2P216MB2102.KORP216.PROD.OUTLOOK.COM>
2024-01-11  7:38     ` Miquel Raynal
2024-01-23  1:01       ` Mohamed Sardi
2024-01-24 17:07         ` Miquel Raynal [this message]
2024-01-25 22:26           ` Mohamed Sardi
2024-02-01 19:40           ` Mohamed Sardi
2024-02-02 16:11             ` Miquel Raynal
2024-02-02 16:17               ` Mohamed Sardi
2024-02-02 17:51                 ` Miquel Raynal
2024-02-21  4:07       ` Kyeongrho.Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124180716.71e26b8c@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Mohammad.nada@skyhighmemory.com \
    --cc=changsub.shim@skyhighmemory.com \
    --cc=kr.kim@skyhighmemory.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=moh.sardi@skyhighmemory.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox