From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mohamed Sardi <moh.sardi@skyhighmemory.com>
Cc: "Changsub.Shim" <changsub.shim@skyhighmemory.com>,
"tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
"p.yadav@ti.com" <p.yadav@ti.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"richard@nod.at" <richard@nod.at>,
Mohammad Nada <Mohammad.nada@skyhighmemory.com>
Subject: Re: [SkyHigh Memory SPI NAND Driver]
Date: Fri, 2 Feb 2024 17:11:36 +0100 [thread overview]
Message-ID: <20240202171136.41699985@xps-13> (raw)
In-Reply-To: <D726EA9A-1C18-4720-A87C-0340D675B514@skyhighmemory.com>
Hi Mohamed,
moh.sardi@skyhighmemory.com wrote on Thu, 1 Feb 2024 19:40:51 +0000:
> Dear Miquel,
> We understand that your plan to turn off the ECC for Bad Block marking and checking... for Linux V6...
No, it's always been like this, I don't think we ever changed that.
Turning ECC on in the raw NAND world was maybe a mistake and was proven
not useful to SPI-NANDs so, it was disabled in the SPI-NAND world from
day 1, AFAIR.
> We also understand that in Linux5.4 the driver did not have ECC control...
Not sure what "driver" means here.
> My question is as follow:
> 1) From which version of Linux ,the ECC control was added in the driver? Was it implemented in Linux 5.xx?
Again, what is "driver"? ECC correction is mandatory for page accesses,
it's always been there.
> 2) What was the leading reason/customer leading to turn off the ECC for bad block marking/checking?
> Note: We saw that MTK was turning off the ECC for Bad block marking on Linux 5.4...
It's not been turned off or on, as I told you in my previous mail.
> 3) We think that the ECC should be turned off for bad block marking and checking, is it possible for us to provide a patch/driver (SHM_core.c) for Linux version version 6... where SHM devices keep the ECC on...
It is already off in the SPI-NAND world. Sorry if I am not
understanding what you say correctly, but I'll need more precise
information to answer correctly.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2024-02-02 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7C13C29F-DBE0-494F-8BA6-99BB68FD08AF@skyhighmemory.com>
2024-01-08 13:47 ` [SkyHigh Memory SPI NAND Driver] Miquel Raynal
2024-01-08 19:05 ` Mohamed Sardi
[not found] ` <SE2P216MB2102316F0F2D8134C755C37283682@SE2P216MB2102.KORP216.PROD.OUTLOOK.COM>
2024-01-11 7:38 ` Miquel Raynal
2024-01-23 1:01 ` Mohamed Sardi
2024-01-24 17:07 ` Miquel Raynal
2024-01-25 22:26 ` Mohamed Sardi
2024-02-01 19:40 ` Mohamed Sardi
2024-02-02 16:11 ` Miquel Raynal [this message]
2024-02-02 16:17 ` Mohamed Sardi
2024-02-02 17:51 ` Miquel Raynal
2024-02-21 4:07 ` Kyeongrho.Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202171136.41699985@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=Mohammad.nada@skyhighmemory.com \
--cc=changsub.shim@skyhighmemory.com \
--cc=linux-mtd@lists.infradead.org \
--cc=moh.sardi@skyhighmemory.com \
--cc=p.yadav@ti.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox